GNOME Bugzilla – Bug 703516
Build failing with EDS backend
Last modified: 2013-08-27 17:01:05 UTC
- Folks 0.9.3 - gobject-introspection 487411db1162323522572f3aebfc423e1706cb69 - gee 0.8.4 - vala 7ff1adb7dd2977d309cb507441f51b3b38681eb5 - evolution-data-server 3.8.3 /home/cassidy/usr/share/gobject-introspection-1.0/Makefile.introspection:153: warning: overriding recipe for target `FolksLibsocialweb-0.6.gir' Makefile:649: warning: ignoring old recipe for target `FolksLibsocialweb-0.6.gir' Making all in eds Making all in lib /home/cassidy/usr/share/gobject-introspection-1.0/Makefile.introspection:153: warning: overriding recipe for target `FolksEds-0.6.gir' Makefile:674: warning: ignoring old recipe for target `FolksEds-0.6.gir' edsf-persona-store.vala:760.41-760.80: error: invocation of void method not allowed as expression this._addressbook = yield E.BookClient.connect (this.source, null); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ edsf-persona-store.vala:1081.17-1081.44: warning: E.Client.open has been deprecated since 3.8 edsf-persona-store.vala:1136.15-1136.47: warning: E.Client.is_opened has been deprecated since 3.8 Compilation failed: 1 error(s), 2 warning(s) make[4]: *** [libfolks_eds_la_vala.stamp] Error 1
(In reply to comment #0) > edsf-persona-store.vala:760.41-760.80: error: invocation of void method not > allowed as expression > this._addressbook = yield E.BookClient.connect (this.source, > null); If you look at $prefix/share/vala/vapi/libebook-1.2.vapi, what does the entry for E.BookClient.connect() look like? For me, I get: public class BookClient : E.Client, GLib.AsyncInitable, GLib.Initable { … public static async E.BookClient connect (E.Source source, GLib.Cancellable? cancellable) throws GLib.Error; … } I’m assuming yours will specify a void return value. I think this was fixed by Simon in this EDS commit: https://git.gnome.org/browse/evolution-data-server/commit/addressbook/libebook/e-book-client.c?id=0e246f1cbded7f2f7f52c364d2c1abf3953b76ec If that’s the case, compiling against EDS ≥3.9.1 should fix your problem. Let me know if it does, and I’ll bump folks’ dependency. The dependency is currently at 3.8.1, and this has definitely compiled in the past, so I wonder if the Vala bindings were somehow temporarily broken in the 3.9.x cycle. I’ll investigate further if compiling against ≥3.9.1 doesn’t work for you.
(In reply to comment #1) > (In reply to comment #0) > > edsf-persona-store.vala:760.41-760.80: error: invocation of void method not > > allowed as expression > > this._addressbook = yield E.BookClient.connect (this.source, > > null); > > If you look at $prefix/share/vala/vapi/libebook-1.2.vapi, what does the entry > for E.BookClient.connect() look like? > > For me, I get: > public class BookClient : E.Client, GLib.AsyncInitable, GLib.Initable { > … > public static async E.BookClient connect (E.Source source, > GLib.Cancellable? cancellable) throws GLib.Error; > … > } > > I’m assuming yours will specify a void return value. Indeed: public static async void connect (E.Source source, GLib.Cancellable? cancellable); > I think this was fixed by > Simon in this EDS commit: > https://git.gnome.org/browse/evolution-data-server/commit/addressbook/libebook/e-book-client.c?id=0e246f1cbded7f2f7f52c364d2c1abf3953b76ec > > If that’s the case, compiling against EDS ≥3.9.1 should fix your problem. Let > me know if it does, and I’ll bump folks’ dependency. The dependency is > currently at 3.8.1, and this has definitely compiled in the past, so I wonder > if the Vala bindings were somehow temporarily broken in the 3.9.x cycle. I’ll > investigate further if compiling against ≥3.9.1 doesn’t work for you. Yep, building with EDS 3.9.1 works.
(In reply to comment #2) > Yep, building with EDS 3.9.1 works. I’ve just bumped the dependency then. Thanks for testing. commit 57621de89d49b06a1db7436de346afdd866b1637 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Wed Jul 31 14:24:58 2013 +0200 build: Bump EDS dependency to 3.9.1 This EDS version fixes a Vala binding which was causing folks to not build. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=703516 NEWS | 4 ++++ configure.ac | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
This fix doesn't seem right. The commit you pointed to was included as far back as evolution-data-server 3.7.92.
(In reply to comment #4) > This fix doesn't seem right. The commit you pointed to was included as far back > as evolution-data-server 3.7.92. Hmm. Is it not working for you, Jeremy? Or are you wanting the dependency pushed back down to make it easier to package? I’m not sure why upgrading to 3.9.1 fixed Guillaume’s build problem then. Stale installed files from EDS?