After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703514 - Can't build FolksTelepathy-0.6.gir
Can't build FolksTelepathy-0.6.gir
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-03 08:28 UTC by Guillaume Desmottes
Modified: 2013-07-05 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Disable fatal warnings when making distcheck (1.37 KB, patch)
2013-07-04 20:58 UTC, Philip Withnall
committed Details | Review

Description Guillaume Desmottes 2013-07-03 08:28:38 UTC
- Folks 0.9.3
- gobject-introspection  487411db1162323522572f3aebfc423e1706cb69
- gee 0.8.4
- vala 7ff1adb7dd2977d309cb507441f51b3b38681eb5

g-ir-scanner: compile: gcc -Wall -Wno-deprecated-declarations -pthread -I/home/cassidy/usr/include/glib-2.0 -I/home/cassidy/usr/lib64/glib-2.0/include -g -I/home/cassidy/gnome/folks -I/home/cassidy/usr/include/glib-2.0 -I/home/cassidy/usr/lib64/glib-2.0/include -I/home/cassidy/usr/include/telepathy-1.0 -I/home/cassidy/usr/include/gee-0.8 -I/home/cassidy/usr/include/gio-unix-2.0/ -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -c -o /home/cassidy/gnome/folks/backends/telepathy/lib/tmp-introspectbjzOC8/FolksTelepathy-0.6.o /home/cassidy/gnome/folks/backends/telepathy/lib/tmp-introspectbjzOC8/FolksTelepathy-0.6.c
g-ir-scanner: link: /bin/sh ../../../libtool --mode=link --tag=CC gcc -o /home/cassidy/gnome/folks/backends/telepathy/lib/tmp-introspectbjzOC8/FolksTelepathy-0.6 -export-dynamic -g -L/home/cassidy/usr/lib64 /home/cassidy/gnome/folks/backends/telepathy/lib/tmp-introspectbjzOC8/FolksTelepathy-0.6.o -L. libfolks-telepathy.la -Wl,--export-dynamic -pthread -L/home/cassidy/usr/lib64 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lrt -lglib-2.0
libtool: link: gcc -o /home/cassidy/gnome/folks/backends/telepathy/lib/tmp-introspectbjzOC8/.libs/FolksTelepathy-0.6 -g /home/cassidy/gnome/folks/backends/telepathy/lib/tmp-introspectbjzOC8/FolksTelepathy-0.6.o -Wl,--export-dynamic -pthread -Wl,--export-dynamic  -L/home/cassidy/usr/lib64 -L. ./.libs/libfolks-telepathy.so -L/lib64 /home/cassidy/usr/lib64/libtelepathy-glib.so -ldbus-glib-1 -ldbus-1 /home/cassidy/gnome/folks/folks/.libs/libfolks.so /home/cassidy/usr/lib64/libgee-0.8.so /home/cassidy/usr/lib64/libgio-2.0.so -lz -lselinux -lresolv /home/cassidy/usr/lib64/libgobject-2.0.so -lffi /home/cassidy/usr/lib64/libgmodule-2.0.so -ldl /home/cassidy/usr/lib64/libglib-2.0.so -lpthread -lrt -pthread -Wl,-rpath -Wl,/home/cassidy/usr/lib64
folks/folks-telepathy.h:68: Warning: FolksTelepathy: tpf_persona_get_contact: return value: Missing (transfer) annotation
folks/folks-telepathy.h:64: Warning: FolksTelepathy: tpf_persona_construct: return value: Missing (transfer) annotation
folks/folks-telepathy.h:65: Warning: FolksTelepathy: tpf_persona_dup_for_contact: return value: Missing (transfer) annotation
folks/folks-telepathy.h:73: Warning: FolksTelepathy: tpf_persona_store_get_account: return value: Missing (transfer) annotation
folks/folks-telepathy.h:70: Warning: FolksTelepathy: tpf_persona_store_construct: return value: Missing (transfer) annotation
folks/folks-telepathy.h:71: Warning: FolksTelepathy: tpf_persona_store_list_persona_stores: return value: Missing (transfer) annotation
folks/folks-telepathy.h:72: Warning: FolksTelepathy: tpf_persona_store_dup_for_account: return value: Missing (transfer) annotation
<unknown>:: Fatal: FolksTelepathy: warnings configured as fatal
<unknown>:: Fatal: FolksTelepathy: warnings configured as fatal

make[4]: *** [FolksTelepathy-0.6.gir] Error 1
Comment 1 Guillaume Desmottes 2013-07-03 08:35:44 UTC
Building with --disable-fatal-warnings works. Aren't fatal warning supposed to be disabled when building releases?
Comment 2 Philip Withnall 2013-07-04 20:44:19 UTC
(In reply to comment #1)
> Building with --disable-fatal-warnings works. Aren't fatal warning supposed to
> be disabled when building releases?

Not currently. A patch to add --disable-fatal-warnings to DISTCHECK_CONFIGURE_FLAGS in the top-level Makefile.am wouldn’t go amiss. I’ll do so later if nobody gets there first.
Comment 3 Philip Withnall 2013-07-04 20:58:02 UTC
Created attachment 248415 [details] [review]
build: Disable fatal warnings when making distcheck

It’s just too painful. They’re normally turned on during development
anyway.

Closes:
Comment 4 Travis Reitter 2013-07-05 16:49:24 UTC
Review of attachment 248415 [details] [review]:

Looks good
Comment 5 Philip Withnall 2013-07-05 18:21:06 UTC
Comment on attachment 248415 [details] [review]
build: Disable fatal warnings when making distcheck

Committed.

commit 8ebe13c457660de380521874a006425083151741
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Jul 4 21:57:04 2013 +0100

    build: Disable fatal warnings when making distcheck
    
    It’s just too painful. They’re normally turned on during development
    anyway.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=703514

 Makefile.am | 1 +
 NEWS        | 2 ++
 2 files changed, 3 insertions(+)