After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703475 - Media art file name do not match tracker's
Media art file name do not match tracker's
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-02 16:05 UTC by Arnel Borja
Modified: 2013-07-16 10:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port media art storage functions from tracker (5.24 KB, patch)
2013-07-12 16:39 UTC, Arnel Borja
committed Details | Review
Update album art tests (4.22 KB, patch)
2013-07-12 16:40 UTC, Arnel Borja
none Details | Review
Port media art storage functions from tracker (5.24 KB, patch)
2013-07-16 10:04 UTC, Vadim Rutkovsky
committed Details | Review

Description Arnel Borja 2013-07-02 16:05:10 UTC
The media art file name creation in albumArtCache.js. For example, blocks are not stripped but instead simply removed (the contents should be stripped too), etc.

https://wiki.gnome.org/MediaArtStorageSpec

I have created a patch for this that I will attach here once ready. It is a port to JavaScript of tracker's functions for this.
Comment 1 Arnel Borja 2013-07-09 13:02:55 UTC
The patches are in https://github.com/kyoushuu/gnome-music.git branch wip/media-art-storage
Comment 2 Arnel Borja 2013-07-12 16:32:25 UTC
The GLib string functions are now replaced with JavaScript functions.
Comment 3 Arnel Borja 2013-07-12 16:39:58 UTC
Created attachment 249026 [details] [review]
Port media art storage functions from tracker

Port normalizeAndHash, stripFindNextBlock and stripInvalidEntities from
tracker to ensure that our media art matches tracker's extracted data.
Comment 4 Arnel Borja 2013-07-12 16:40:44 UTC
Created attachment 249027 [details] [review]
Update album art tests
Comment 5 Vadim Rutkovsky 2013-07-16 10:03:58 UTC
The following fix has been pushed:
d358cb0 Port media art storage functions from tracker
Comment 6 Vadim Rutkovsky 2013-07-16 10:04:08 UTC
Created attachment 249261 [details] [review]
Port media art storage functions from tracker

Port normalizeAndHash, stripFindNextBlock and stripInvalidEntities from
tracker to ensure that our media art matches tracker's extracted data.