After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703418 - Make autorun notifications work
Make autorun notifications work
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-01 20:54 UTC by Matthias Clasen
Modified: 2013-07-02 01:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make autorun notifications work (1.15 KB, patch)
2013-07-01 20:54 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2013-07-01 20:54:00 UTC
The code that checks for various conditions is confusing and
undercommented. It appears one of the recent refactorings
inadvertedly inverted the sense of the 'hidden mountpoint'
check, and caused autorun to not work for anything that does
not have a 'native root' - which is pretty much all volumes
implemented by gvfs.
Comment 1 Matthias Clasen 2013-07-01 20:54:02 UTC
Created attachment 248186 [details] [review]
Make autorun notifications work
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-07-01 20:56:50 UTC
Review of attachment 248186 [details] [review]:

OK.
Comment 3 Matthias Clasen 2013-07-02 01:47:19 UTC
Attachment 248186 [details] pushed as 793edd3 - Make autorun notifications work