Created attachment 248177 [details] [review]
network: Use gnome-settings-daemon interface for switching on/off Airplane Mode

Review of attachment 248177 [details] [review]:

The D-Bus API has changed, so this will need updating.

Created attachment 249296 [details] [review]
network: Use gnome-settings-daemon interface for switching on/off Airplane Mode

Having this in one place is a lot cleaner.

Review of attachment 249296 [details] [review]:

::: panels/network/cc-network-panel.c
@@ +287,3 @@
+                           -1,
+                           priv->cancellable,
+                           set_brightness_cb,

set_brightness_cb?

@@ +305,1 @@
+        g_variant_get (result, "b", &enabled);

enabled = g_variant_get_boolean (result);

@@ +324,3 @@
+        panel->priv->rfkill_proxy = g_dbus_proxy_new_for_bus_finish (res, &error);
+        if (panel->priv->rfkill_proxy == NULL) {
+                g_printerr ("Error creating proxy: %s\n", error->message);

"creating rfkill proxy"

Created attachment 249364 [details] [review]
network: Use gnome-settings-daemon interface for switching on/off Airplane Mode

Having this in one place is a lot cleaner.

Created attachment 249365 [details] [review]
network: Use gnome-settings-daemon interface for switching on/off Airplane Mode

Having this in one place is a lot cleaner.

Review of attachment 249365 [details] [review]:

::: panels/network/cc-network-panel.c
@@ +80,2 @@
         /* Killswitch stuff */
+        GDBusProxy       *rfkill_proxy;

Missing an unref in ->dispose.

Looks good after that.

Attachment 249365 [details] pushed as 085e769 - network: Use gnome-settings-daemon interface for switching on/off Airplane Mode