After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703403 - boxpointer: fix left/right arrow side calculation
boxpointer: fix left/right arrow side calculation
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-01 16:42 UTC by Emilio Pozuelo Monfort
Modified: 2013-07-01 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
boxpointer: fix left/right arrow side calculation (1.42 KB, patch)
2013-07-01 16:42 UTC, Emilio Pozuelo Monfort
committed Details | Review
screenshot (412.87 KB, image/png)
2013-07-01 16:43 UTC, Emilio Pozuelo Monfort
  Details

Description Emilio Pozuelo Monfort 2013-07-01 16:42:01 UTC
Commit d6cace32 introduced a typo in the left/right arrow side
calculation code that causes in most scenarios (where the monitor
width is greater then the height) to not flip the box when it doesn't
fit inside the monitor.
Comment 1 Emilio Pozuelo Monfort 2013-07-01 16:42:04 UTC
Created attachment 248164 [details] [review]
boxpointer: fix left/right arrow side calculation
Comment 2 Emilio Pozuelo Monfort 2013-07-01 16:43:32 UTC
Created attachment 248165 [details]
screenshot
Comment 3 Emilio Pozuelo Monfort 2013-07-01 16:44:46 UTC
I have verified the fix in 3.8.3 on a LTR locale. Right clicking icedove as in the attached screenshot pops the menu to the left of the icon.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-07-01 16:48:18 UTC
Review of attachment 248164 [details] [review]:

OK.
Comment 5 Emilio Pozuelo Monfort 2013-07-01 16:55:51 UTC
Committed to master and gnome-3-8.