GNOME Bugzilla – Bug 703394
'Paste' option from 'Edit' menu is always enabled
Last modified: 2013-07-23 09:33:48 UTC
Steps to reproduce: 1. Start system and log in (or Reboot in order to clear cache) 2. Go to Applications and select "Password and keys" 3. Click "Edit" from menu Expected result: "Paste" should be disabled Actual result: "Paste" is enabled. Clicking "Paste" option would not paste anything Note: "Gedit" application has "Paste" option disabled
Created attachment 248465 [details] [review] Only permit import from clipboard when data is available
Review of attachment 248465 [details] [review]: ::: src/seahorse-key-manager.c @@ +389,3 @@ + gboolean text_available; + + text_available = gtk_clipboard_wait_is_text_available (clipboard); Does this function block for a significant amount of time? Other than that the patch looks good to me. Otherwise, we can use gtk_clipboard_request_contents() + callback which calls gtk_selection_data_targets_include_text().
I haven't experienced any blocks using this. I chose it because it takes less time than actually pulling the text from the clipboard, as opposed to the gtk_clipboard_request methods
Makes sense. Thanks for this patch. I added one little check for NULL text, but other than that, pushed. commit e76c46a7f4bfca6df0851be01df49d5053e03218 Author: Michael I Doherty <michael.i.doherty@intel.com> Date: Fri Jul 5 15:37:17 2013 +0100 Only permit import from clipboard when data is available
Ah good call, thanks :)
I confirm this is working but I had to adapt it for gnome-3-8 branch Just ask it, it anyone care of this...