Created attachment 248128 [details] [review]
session: don't close outside connections during session reset

If a user clicks cancel in the login screen the underlying
user verification session gets reset, which causes the greeter
connection to get scrubbed from the record.

Resetting is correct, but scrubbing the connection isn't.

The bug manifests itself at login time, by the greeter not fading
out if the user hit cancel once before logging in.  Instead, the
greeter gets kill right away and login proceeds abruptly.

This commit makes gdm_session_reset not erreoneously do this connection
scrubbing.

Created attachment 248129 [details] [review]
slave: don't assume autologin if there are no connections

Because of a bug in gdm-session.c (which was dealt with in
the previous commit) we ended up with a false impression of currently
connected clients after a session reset happens.

That bug meant the slave assumed autologin was enabled which
stopped it from waiting for the greeter to finish the fade out before
proceeding.

Assuming "no connection" == "autologin" is a bit fragile, so this
commit makes sure to check for gdm-autologin specifically.

(pushing since I don't think I'll get a reviewer on these, but if someone wants to take a look, I'd appreciate it)

Attachment 248128 [details] pushed as cc2e401 - session: don't close outside connections during session reset
Attachment 248129 [details] pushed as 20a1eee - slave: don't assume autologin if there are no connections