After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703369 - Fix build warnings about string format
Fix build warnings about string format
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
Depends on:
Blocks:
 
 
Reported: 2013-07-01 07:51 UTC by Alban Browaeys
Modified: 2013-07-03 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build warnings about string format (1.88 KB, patch)
2013-07-01 07:51 UTC, Alban Browaeys 		needs-work Details | Review
Fix build warnings about string format (v2) (1.88 KB, patch)
2013-07-01 18:01 UTC, Alban Browaeys 		committed Details | Review

Description Alban Browaeys 2013-07-01 07:51:15 UTC 
Created attachment 248118 [details] [review]
Fix build warnings about string format

Fixes warning about the string format specifiers  not matching
 the type of the arguments.

/home/prahal/Projects/Devel/Gnome/jhbuild/gnome/totem/src/backend/bacon-video-widget.c: In function 'bvw_download_buffering_done':
/home/prahal/Projects/Devel/Gnome/jhbuild/gnome/totem/src/backend/bacon-video-widget.c:1929:5: warning: format '%lld' expects argument of type 'long long int', but argument 8 has type 'gint64' [-Wformat=]
     GST_DEBUG ("Buffering left: %lld * %f = %lld < %lld",
     ^
/home/prahal/Projects/Devel/Gnome/jhbuild/gnome/totem/src/backend/bacon-video-widget.c:1929:5: warning: format '%lld' expects argument of type 'long long int', but argument 10 has type 'double' [-Wformat=]
/home/prahal/Projects/Devel/Gnome/jhbuild/gnome/totem/src/backend/bacon-video-widget.c:1929:5: warning: format '%lld' expects argument of type 'long long int', but argument 11 has type 'gint64' [-Wformat=]
Comment 1 Bastien Nocera 2013-07-01 07:55:22 UTC 
Review of attachment 248118 [details] [review]:

::: src/backend/bacon-video-widget.c
@@ +1930,1 @@
 	       bvw->priv->buffering_left, BUFFERING_LEFT_RATIO,

buffering_left is a gint64, so you should use that as the format, not guint64.
Comment 2 Alban Browaeys 2013-07-01 18:01:03 UTC 
Created attachment 248174 [details] [review]
Fix build warnings about string format (v2)

thanks. Fixed the gint64 vs guint6 mess up in the previous patch.