After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703359 - retain history defaults to 1 day
retain history defaults to 1 day
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Privacy
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-30 19:11 UTC by William Jon McCann
Modified: 2013-07-01 07:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
privacy: Fix default "Retain history" value (1.14 KB, patch)
2013-07-01 07:08 UTC, Bastien Nocera 		committed Details | Review

Description William Jon McCann 2013-06-30 19:11:07 UTC 
Retain history defaults to 1 day. That does not sound like a good default.

I would say "Forever" is better and safer.
Comment 1 Bastien Nocera 2013-07-01 07:08:36 UTC 
It already defaults to "forever":
    <key name="recent-files-max-age" type="i">
      <default>-1</default>
      <_summary>Number of days to remember recently used files for</_summary>
      <_description>Recently used files will be remembered for this many days.
        If set to 0, recent files will not be remembered; if set to -1, they
        will be retained indefinitively.</_description>
    </key>
Comment 2 Bastien Nocera 2013-07-01 07:08:48 UTC 
Created attachment 248113 [details] [review]
privacy: Fix default "Retain history" value

Our loop to set the combo box to the current value of
recent-files-max-age didn't work properly for the negative (and default)
-1 value that means "Forever". This fixes the default display value.
Comment 3 Bastien Nocera 2013-07-01 07:09:06 UTC 
Attachment 248113 [details] pushed as 1fd7812 - privacy: Fix default "Retain history" value