After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703313 - Improve documentation of the GtkTextView API
Improve documentation of the GtkTextView API
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
3.9.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-06-29 15:01 UTC by Sébastien Wilmet
Modified: 2013-06-30 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
textiter: doc precision for forward_search() and backward_search() (1.27 KB, patch)
2013-06-29 15:02 UTC, Sébastien Wilmet 		committed Details | Review
textiter: better document "tag" functions (3.38 KB, patch)
2013-06-29 16:29 UTC, Sébastien Wilmet 		needs-work Details | Review
textiter: better document "tag" functions (3.11 KB, patch)
2013-06-29 17:35 UTC, Sébastien Wilmet 		accepted-commit_now Details | Review

Description Sébastien Wilmet 2013-06-29 15:01:26 UTC 
I'll attach a patch soon.
Comment 1 Sébastien Wilmet 2013-06-29 15:02:01 UTC 
Created attachment 248050 [details] [review]
textiter: doc precision for forward_search() and backward_search()
Comment 2 Sébastien Wilmet 2013-06-29 16:29:00 UTC 
Created attachment 248054 [details] [review]
textiter: better document "tag" functions
Comment 3 Paolo Borelli 2013-06-29 17:04:56 UTC 
Review of attachment 248050 [details] [review]:

looks good
Comment 4 Paolo Borelli 2013-06-29 17:07:56 UTC 
Review of attachment 248054 [details] [review]:

::: gtk/gtktextiter.c
@@ +1165,3 @@
+ * Note that if gtk_text_iter_begins_tag() returns %TRUE, @iter is at the
+ * beginning of the tagged range, and the <emphasis>character</emphasis> at
+ * range. In other words, if gtk_text_iter_begins_tag() returns %TRUE,

this sentence is strange... I was expecting "if A and B *then* something"
Comment 5 Sébastien Wilmet 2013-06-29 17:35:05 UTC 
Created attachment 248056 [details] [review]
textiter: better document "tag" functions
Comment 6 Paolo Borelli 2013-06-29 19:10:36 UTC 
Review of attachment 248056 [details] [review]:

looks good now
Comment 7 Sébastien Wilmet 2013-06-30 08:40:09 UTC 
Pushed, thanks.