After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703280 - Rename all singleton public constructors to _dup_singleton()
Rename all singleton public constructors to _dup_singleton()
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-28 17:57 UTC by Emanuele Aina
Modified: 2013-08-23 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename all singleton public constructors to _dup_singleton() (38.84 KB, patch)
2013-06-28 17:57 UTC, Emanuele Aina 		none Details | Review
Rename all singleton public constructors to _dup_singleton() (50.85 KB, patch)
2013-08-22 11:37 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-06-28 17:57:00 UTC 
Using _dup_singleton() instead of _new() makes more clear that we're not
really allocating a new object, but just taking a reference to an
already existing one.
Comment 1 Emanuele Aina 2013-06-28 17:57:04 UTC 
Created attachment 248005 [details] [review]
Rename all singleton public constructors to _dup_singleton()

Using _dup_singleton() instead of _new() makes more clear that we're not
really allocating a new object, but just taking a reference to an
already existing one.
Comment 2 Emanuele Aina 2013-08-22 11:37:26 UTC 
Created attachment 252718 [details] [review]
Rename all singleton public constructors to _dup_singleton()

Rebase on top of current master.
Comment 3 Debarshi Ray 2013-08-23 14:42:07 UTC 
Review of attachment 252718 [details] [review]:

Looks good, and thanks for rebasing it.