GNOME Bugzilla – Bug 703263
Crash while freeing subscription data
Last modified: 2013-10-16 13:08:04 UTC
Another crash, not coming from Rygel:
This seems to be reproducible ctrl-c-ing Rygel after running UDA-4.1.9, where the test issues a notify with an unresolvable hostname, which seems to leave an invalid soup message
Seems like it's not possible to requeue the message in this case and message is unreffed after leaving the callback, so we have a dangling pointer there.
Created attachment 252022 [details] [review]
Do not try to reuse message on error
If one of the call-backs has an error, just recreate the soup message. If we
want to re-use the old soup message we need to get the reference counting
right etc. This could lead to cases where notifications were not sent properly
because the first URL was failing and the requeuing failed as well.
Also it caused crashes by leaving a dangling pointer in pending_messages.
*** Bug 705901 has been marked as a duplicate of this bug. ***
Attachment 252022 [details] pushed as 00a73ff - Do not try to reuse message on error