After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703247 - Ensure strings from xkeyboard-config are UTF-8
Ensure strings from xkeyboard-config are UTF-8
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-28 13:34 UTC by Christophe Fergeau
Modified: 2013-06-28 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ensure strings from xkeyboard-config are UTF-8 (1.33 KB, patch)
2013-06-28 13:34 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2013-06-28 13:34:26 UTC 
When using g_dgettext, translated strings are returned in the
current locale's encoding. This means XKEYBOARD_CONFIG() can
give us a non-UTF-8 string if a non-UTF-8 locale is in use.
Calling bind_textdomain_codeset() ensures that the strings returned
by g_dgettext will be encoded in UTF-8, which is what applications
using gnome-desktop expect.
Comment 1 Christophe Fergeau 2013-06-28 13:34:27 UTC 
Created attachment 247984 [details] [review]
Ensure strings from xkeyboard-config are UTF-8
Comment 2 Rui Matos 2013-06-28 14:25:46 UTC 
Review of attachment 247984 [details] [review]:

If this fixes the issue, looks fine. Thanks
Comment 3 Christophe Fergeau 2013-06-28 14:42:12 UTC 
Review of attachment 247984 [details] [review]:

Yes I've tested this fixes the issue. Thanks for the quick review!