GNOME Bugzilla – Bug 703233
When you drag a file in nautilus, it updates page
Last modified: 2013-07-30 21:20:40 UTC
Description of problem: Since I upgraded to Fedora 19 RC2, nautilus has an annoying behavior when dragging a file as it updates the page. This is a big problem, and that having a lot of files, I have a little delay precludes an action properly. Version-Release number of selected component (if applicable): fedora 19 gnome 3.8.3 nautilus 3.8.2 How reproducible: always Steps to Reproduce: 1.Open nautilus (icon view) 2.Drag a file to move it to a folder Actual results: Upon dragging the file, nautilus refresh the page. This hinders the action because for a second place is unknown destination folder (if the action is done quickly, the file you are trying to move may end up in another folder). Expected results: The Nautilus page is not updated when dragging a file.
*** Bug 704652 has been marked as a duplicate of this bug. ***
List view is also affected by this bug, not only icon view.
(In reply to comment #2) > List view is also affected by this bug, not only icon view. You are absolutely right, however, when I reported it only affected the icon view. Actually this behavior is very annoying, I hope they can do something.
(In reply to comment #3) > (In reply to comment #2) > > List view is also affected by this bug, not only icon view. > > You are absolutely right, however, when I reported it only affected the icon > view. Ok. > > Actually this behavior is very annoying, I hope they can do something. I have some good news, I've spotted the issue and have a working patch, but I won't be able to post it till monday. Have a nice weekend.
Created attachment 250348 [details] [review] Fix for bug 703233 This bug was introduced in commit 0d635bda where the logic to open locations on hover did not take into account to not doing it for the current (starting drag) location.
Created attachment 250365 [details] [review] Fix v2 for bug 703233 My prior patch was wrong in that it was freeing the GFile returned by nautilus_window_slot_get_location() which is not needed and so I was seeing some crashes due to that, fixed that and also add a null check for the returned value.
Review of attachment 250365 [details] [review]: Thanks, this looks good to me.
(In reply to comment #6) Thank you very much.
(In reply to comment #7) > Review of attachment 250365 [details] [review]: > > Thanks, this looks good to me. Pushed as e2b48065 thank you!