After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703079 - Clutter Animations and Groups are deprecated (patch attached)
Clutter Animations and Groups are deprecated (patch attached)
Status: RESOLVED FIXED
Product: quadrapassel
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Mario Wenzel
quadrapassel-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-25 20:56 UTC by Mario Wenzel
Modified: 2013-07-18 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch removing deprecated Clutter Group and Clutter Animations (9.67 KB, patch)
2013-06-25 20:56 UTC, Mario Wenzel
reviewed Details | Review
Fixed patch for removing clutter animation deprecation messages (9.71 KB, patch)
2013-07-18 15:37 UTC, Mario Wenzel
committed Details | Review

Description Mario Wenzel 2013-06-25 20:56:17 UTC
Clutter Groups and Animations are deprecated. I refactored the code against clutter 1.14. The only thing missing is the ClutterTexture-Stuff but I don't know where to start there.
Comment 1 Mario Wenzel 2013-06-25 20:56:46 UTC
Created attachment 247777 [details] [review]
Patch removing deprecated Clutter Group and Clutter Animations
Comment 2 Michael Catanzaro 2013-07-12 02:31:56 UTC
Review of attachment 247777 [details] [review]:

Solves the majority of the clutter warnings; only the texture issues remain.

There are a few formatting issues that need fixed, though: looks like there's a hard tab added to shape_dropped_cb, and about half of the time you forgot to leave a space between a method name and the opening parenthesis.  (That's something that'll happen a lot for the first month or so, until you're used to the style.)
Comment 3 Mario Wenzel 2013-07-18 13:45:38 UTC
The edited patch is now in master
Comment 4 Mario Wenzel 2013-07-18 15:37:25 UTC
Created attachment 249533 [details] [review]
Fixed patch for removing clutter animation deprecation messages