After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703055 - overlay help/settings fades in on the primary display only
overlay help/settings fades in on the primary display only
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Joaquim Rocha
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-25 13:02 UTC by Jakub Steiner
Modified: 2013-07-04 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wacom: Prevent OSD flashing on primary screen (1.23 KB, patch)
2013-06-28 13:19 UTC, Joaquim Rocha 		rejected Details | Review
wacom: Prevent OSD flashing on primary screen (3.09 KB, patch)
2013-07-04 15:12 UTC, Joaquim Rocha 		accepted-commit_now Details | Review

Description Jakub Steiner 2013-06-25 13:02:48 UTC 
when you map your tablet to a secondary screen and then show the overlay help, it fades in on the primary screen and then flips to the screen the tablet is mapped to.
Comment 1 Joaquim Rocha 2013-06-28 13:19:27 UTC 
Created attachment 247983 [details] [review]
wacom: Prevent OSD flashing on primary screen

Setting the OSD's default size (when realized) was showing it before it was
moved to the right monitor and made fullscreen.
Comment 2 Bastien Nocera 2013-07-02 14:59:50 UTC 
Review of attachment 247983 [details] [review]:

::: plugins/wacom/gsd-wacom-osd-window.c
@@ -1393,3 @@
 	}
 
-	gtk_window_set_default_size (GTK_WINDOW (osd_window),

If the window is simply realized, then nothing should be showing on the screen. It should only show when you show/present it.
Comment 3 Joaquim Rocha 2013-07-04 15:12:07 UTC 
Created attachment 248394 [details] [review]
wacom: Prevent OSD flashing on primary screen

Delete the map callback and move its code to the realize one so
the window is moved to the right monitor and set to fullscreen
right after being resized and before being shown.
Comment 4 Bastien Nocera 2013-07-04 15:13:31 UTC 
Review of attachment 248394 [details] [review]:

Rest looks fine.

::: plugins/wacom/gsd-wacom-osd-window.c
@@ +1376,3 @@
 	gtk_window_set_default_size (GTK_WINDOW (osd_window),
+				     osd_window->priv->screen_area.width,
+				     osd_window->priv->screen_area.height);

No whitespace changes please.
Comment 5 Joaquim Rocha 2013-07-04 16:55:25 UTC 
commit 10895a858ba6b60f697d903bc82a28bb0d711639

Pushed after "reverted" whitespace.