GNOME Bugzilla – Bug 703044
DescriptionFile.set_device_element() should create elements if they do not exists
Last modified: 2013-06-27 12:15:08 UTC
Setting the contents of non-required elements dynamically in the description doc does not work (unless an empty element is added into the template xml first). It makes more sense to create the whole element dynamically in this case: this way the default xml size does not grow. I'll attach a patch.
True.
Created attachment 247721 [details] [review] DescriptionFile: create device elements if they do not exists set_device_element() may be called with names of elements that do not exists yet (non-required elements that are empty by default). Create elements dynamically in set_device_element(). also, remove the X_DLNACAP element if the contents are empty.
Created attachment 247722 [details] [review] DescriptionFile: create device elements if they do not exists set_device_element() may be called with names of elements that do not exists yet (non-required elements that are empty by default). Create elements dynamically in set_device_element(). also, remove the X_DLNACAP element if the contents are empty.
Agree on the patch, might interfere with https://bugzilla.gnome.org/show_bug.cgi?id=702451 though. (That's a warning, not a fail)
Comment on attachment 247722 [details] [review] DescriptionFile: create device elements if they do not exists Marking obsolete as the patch set in bug 702451 covers this (and also sets the "dlna" namespace correctly).