After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703038 - Add new GtkKeyShortcutButton
Add new GtkKeyShortcutButton
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-06-25 09:45 UTC by Joaquim Rocha
Modified: 2018-05-02 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add new GtkKeyShortcutButton (22.92 KB, patch)
2013-06-25 09:45 UTC, Joaquim Rocha
reviewed Details | Review
demo: Add GtkKeyShortcutButton demo (5.46 KB, patch)
2013-06-25 09:47 UTC, Joaquim Rocha
none Details | Review
Add new GtkKeyShortcutButton (25.08 KB, patch)
2013-07-02 14:48 UTC, Joaquim Rocha
none Details | Review

Description Joaquim Rocha 2013-06-25 09:45:42 UTC
This button works as the GtkCellRendererAccel but is more flexible and it's a plain GtkWidget so it can be used e.g. with a ListBox.
Comment 1 Joaquim Rocha 2013-06-25 09:45:47 UTC
Created attachment 247711 [details] [review]
Add new GtkKeyShortcutButton
Comment 2 Joaquim Rocha 2013-06-25 09:47:03 UTC
Created attachment 247712 [details] [review]
demo: Add GtkKeyShortcutButton demo
Comment 3 Matthias Clasen 2013-06-27 10:27:58 UTC
Review of attachment 247711 [details] [review]:

The commit message should have at least one sentence about the new widget, not just the bug reference.

Looks fine to me, code-wise (haven't tried it).

When committing this, you need to hook it up to the docs (add the type to gtk3.types.in, add the api to gtk-sections.txt, include the new section in gtk-docs.sgml

::: gtk/gtkkeyshortcutbutton.c
@@ +539,3 @@
+                       0,
+                       G_PARAM_READWRITE |
+                       G_PARAM_STATIC_STRINGS);

The last two should have the default value that is set in _init
Comment 4 Joaquim Rocha 2013-07-02 14:48:30 UTC
Created attachment 248233 [details] [review]
Add new GtkKeyShortcutButton

This new version addresses the comments by Matthias; adds the padding to the class struct and corrects a small bug.
Comment 5 Daniel Boles 2017-08-16 08:51:17 UTC
This seems like a nice idea (assuming all the other places where I've seen similar widgets had to roll their own, i.e. we don't already have something else)

If this still adds useful functionality and can be applied, can it be considered for GTK+ 4? And maybe 3, though I'm guessing that's a lot less likely.
Comment 6 GNOME Infrastructure Team 2018-05-02 15:41:43 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/430.