GNOME Bugzilla – Bug 703038
Add new GtkKeyShortcutButton
Last modified: 2018-05-02 15:41:43 UTC
This button works as the GtkCellRendererAccel but is more flexible and it's a plain GtkWidget so it can be used e.g. with a ListBox.
Created attachment 247711 [details] [review] Add new GtkKeyShortcutButton
Created attachment 247712 [details] [review] demo: Add GtkKeyShortcutButton demo
Review of attachment 247711 [details] [review]: The commit message should have at least one sentence about the new widget, not just the bug reference. Looks fine to me, code-wise (haven't tried it). When committing this, you need to hook it up to the docs (add the type to gtk3.types.in, add the api to gtk-sections.txt, include the new section in gtk-docs.sgml ::: gtk/gtkkeyshortcutbutton.c @@ +539,3 @@ + 0, + G_PARAM_READWRITE | + G_PARAM_STATIC_STRINGS); The last two should have the default value that is set in _init
Created attachment 248233 [details] [review] Add new GtkKeyShortcutButton This new version addresses the comments by Matthias; adds the padding to the class struct and corrects a small bug.
This seems like a nice idea (assuming all the other places where I've seen similar widgets had to roll their own, i.e. we don't already have something else) If this still adds useful functionality and can be applied, can it be considered for GTK+ 4? And maybe 3, though I'm guessing that's a lot less likely.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/430.