After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703034 - gnome-rr: Fix crash when XRRSetCrtcConfig() fails
gnome-rr: Fix crash when XRRSetCrtcConfig() fails
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-25 09:10 UTC by Bastien Nocera
Modified: 2013-06-26 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-rr: Fix crash when XRRSetCrtcConfig() fails (1.65 KB, patch)
2013-06-25 09:10 UTC, Bastien Nocera
reviewed Details | Review
gnome-rr: Fix crash when XRRSetCrtcConfig() fails (1.63 KB, patch)
2013-06-26 18:32 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-06-25 09:10:48 UTC
.
Comment 1 Bastien Nocera 2013-06-25 09:10:50 UTC
Created attachment 247709 [details] [review]
gnome-rr: Fix crash when XRRSetCrtcConfig() fails

It's possible for XRRSetCrtcConfig() to fail so we should
wrap it in gkd_error_traps.
Comment 2 Matthias Clasen 2013-06-26 18:30:06 UTC
Review of attachment 247709 [details] [review]:

Looks good otherwise

::: libgnome-desktop/gnome-rr.c
@@ +2262,3 @@
 
+    gdk_flush ();
+    if (gdk_error_trap_pop () || status != RRSetConfigSuccess) {

I don' think you need the flush here. gdk_error_trap_pop already calls XSync when needed.
Comment 3 Bastien Nocera 2013-06-26 18:32:53 UTC
Created attachment 247850 [details] [review]
gnome-rr: Fix crash when XRRSetCrtcConfig() fails

It's possible for XRRSetCrtcConfig() to fail so we should
wrap it in gkd_error_traps.
Comment 4 Bastien Nocera 2013-06-26 18:33:13 UTC
Attachment 247850 [details] pushed as 4a95c17 - gnome-rr: Fix crash when XRRSetCrtcConfig() fails