GNOME Bugzilla – Bug 703034
gnome-rr: Fix crash when XRRSetCrtcConfig() fails
Last modified: 2013-06-26 18:33:18 UTC
.
Created attachment 247709 [details] [review] gnome-rr: Fix crash when XRRSetCrtcConfig() fails It's possible for XRRSetCrtcConfig() to fail so we should wrap it in gkd_error_traps.
Review of attachment 247709 [details] [review]: Looks good otherwise ::: libgnome-desktop/gnome-rr.c @@ +2262,3 @@ + gdk_flush (); + if (gdk_error_trap_pop () || status != RRSetConfigSuccess) { I don' think you need the flush here. gdk_error_trap_pop already calls XSync when needed.
Created attachment 247850 [details] [review] gnome-rr: Fix crash when XRRSetCrtcConfig() fails It's possible for XRRSetCrtcConfig() to fail so we should wrap it in gkd_error_traps.
Attachment 247850 [details] pushed as 4a95c17 - gnome-rr: Fix crash when XRRSetCrtcConfig() fails