After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703013 - Add man pages
Add man pages
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-24 21:59 UTC by Matthias Clasen
Modified: 2013-06-26 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add man pages (11.42 KB, patch)
2013-06-24 21:59 UTC, Matthias Clasen 		reviewed Details | Review
Add man pages (11.94 KB, patch)
2013-06-26 04:00 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2013-06-24 21:59:25 UTC 
This patch adds man pages describing glade and glade-previewer.
Comment 1 Matthias Clasen 2013-06-24 21:59:27 UTC 
Created attachment 247685 [details] [review]
Add man pages
Comment 2 Tristan Van Berkom 2013-06-25 06:29:02 UTC 
Comment on attachment 247685 [details] [review]
Add man pages

Cool ! :)

Some little nitpicks on the patch.

From the looks of the Makefile.am, the build data goes into EXTRA_DIST
sort of like built gtk-doc does, for that reason I think that the
--enable-documentation switch should go into the DISTCHECK_CONFIGURE_FLAGS
in the toplevel Makefile.am.

Is this not done because build servers need to roll tarballs without an
internet connection ? (which it seems is required to actually build the
man pages).

Also the glade-previewer has the interesting new --css and --screenshot
options.

Finally, I think I would prefer something like --enable-man-pages
as an option than --enable-documentation, but I could always change that
afterwards.
Comment 3 Matthias Clasen 2013-06-26 04:00:34 UTC 
Created attachment 247789 [details] [review]
Add man pages
Comment 4 Matthias Clasen 2013-06-26 04:01:28 UTC 
You don't need to be on the internet to roll tarballs, but you do need to have the docbook stylesheets installed locally.
Comment 5 Tristan Van Berkom 2013-06-26 04:31:46 UTC 
Comment on attachment 247789 [details] [review]
Add man pages

Thanks, please commit.
Comment 6 Matthias Clasen 2013-06-26 17:58:31 UTC 
Attachment 247789 [details] pushed as a2ba7b9 - Add man pages