After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702986 - mouse: use a dialog window for the mouse test
mouse: use a dialog window for the mouse test
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Mouse
unspecified
Other All
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-24 14:52 UTC by Thomas Wood
Modified: 2013-06-25 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mouse: use a dialog window for the mouse test (5.18 KB, patch)
2013-06-24 14:52 UTC, Thomas Wood 		none Details | Review
This patch increases the window height and reduces the width slightly, as (6.37 KB, patch)
2013-06-25 14:40 UTC, Thomas Wood 		committed Details | Review

Description Thomas Wood 2013-06-24 14:52:09 UTC 
This avoids using a toggle button to switch to the test area and makes the
interaction more consistent with other panels.
Comment 1 Thomas Wood 2013-06-24 14:52:11 UTC 
Created attachment 247650 [details] [review]
mouse: use a dialog window for the mouse test

This avoids using a toggle button to switch to the test area and makes the
interaction more consistent with other panels.
Comment 2 Allan Day 2013-06-24 15:22:42 UTC 
Looks good. I'd make the dialog about 140px taller.

Also, while the dialog width is right for the content, it is a bit strange having it the same width as the parent window - I'd increase the width a bit just to differentiate the two.
Comment 3 Thomas Wood 2013-06-25 14:40:23 UTC 
Created attachment 247742 [details] [review]
This patch increases the window height and reduces the width slightly, as

discussed on IRC. Also fixes a crash when closing the shell window.
Comment 4 Allan Day 2013-06-25 15:23:58 UTC 
Much better. Looks good to me.
Comment 5 Thomas Wood 2013-06-25 15:32:51 UTC 
Patch pushed to master.