After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702950 - Media keys don't handle Stop
Media keys don't handle Stop
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-24 09:15 UTC by Vadim Rutkovsky
Modified: 2013-06-27 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug #702950 - Media keys don't handle Stop (694 bytes, patch)
2013-06-26 08:36 UTC, Fabiano Fidêncio 		needs-work Details | Review
Use MPRIS method for multimedia keys (1.30 KB, patch)
2013-06-27 00:07 UTC, Fabiano Fidêncio 		none Details | Review
Bug #702950 - Media keys don't handle Stop (1.14 KB, patch)
2013-06-27 00:07 UTC, Fabiano Fidêncio 		none Details | Review
Bug #702950 - Media keys don't handle Stop (1.14 KB, patch)
2013-06-27 09:38 UTC, Vadim Rutkovsky 		committed Details | Review
Use MPRIS method for multimedia keys (1.30 KB, patch)
2013-06-27 09:38 UTC, Vadim Rutkovsky 		committed Details | Review

Description Vadim Rutkovsky 2013-06-24 09:15:45 UTC 
* Start playback
* Click Stop

Expected: the playback should be stoped, progress position is 0, state is paused
Comment 1 Fabiano Fidêncio 2013-06-26 08:36:01 UTC 
Created attachment 247797 [details] [review]
Bug #702950 - Media keys don't handle Stop
Comment 2 Vadim Rutkovsky 2013-06-26 08:56:53 UTC 
Review of attachment 247797 [details] [review]:

Doesn't rewind to position 0 (now acts same as pause)
Comment 3 Fabiano Fidêncio 2013-06-27 00:07:35 UTC 
Created attachment 247864 [details] [review]
Use MPRIS method for multimedia keys
Comment 4 Fabiano Fidêncio 2013-06-27 00:07:39 UTC 
Created attachment 247865 [details] [review]
Bug #702950 - Media keys don't handle Stop
Comment 5 Vadim Rutkovsky 2013-06-27 09:38:26 UTC 
Great job, thanks

The following fixes have been pushed:
47fb034 Bug #702950 - Media keys don't handle Stop
c89066f Use MPRIS method for multimedia keys
Comment 6 Vadim Rutkovsky 2013-06-27 09:38:30 UTC 
Created attachment 247882 [details] [review]
Bug #702950 - Media keys don't handle Stop
Comment 7 Vadim Rutkovsky 2013-06-27 09:38:33 UTC 
Created attachment 247883 [details] [review]
Use MPRIS method for multimedia keys