After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702922 - Meetings with no attendees are treated as Appointment
Meetings with no attendees are treated as Appointment
Status: RESOLVED FIXED
Product: evolution-ews
Classification: Other
Component: Calendar
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Evolution EWS maintainer(s)
Evolution EWS maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-24 01:32 UTC by Fabiano Fidêncio
Modified: 2013-08-16 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bug 702922 - Meetings with no attendees are treated as Appointment (2.15 KB, patch)
2013-06-24 01:36 UTC, Fabiano Fidêncio
committed Details | Review
ews patch (regression fix) (1.01 KB, patch)
2013-08-16 09:40 UTC, Milan Crha
committed Details | Review

Description Fabiano Fidêncio 2013-06-24 01:32:10 UTC
Description of problem:
A meeting saved with no attendees, after a server refresh, is shown as an appointment.
Comment 1 Fabiano Fidêncio 2013-06-24 01:36:41 UTC
Created attachment 247576 [details] [review]
Bug 702922 - Meetings with no attendees are treated as Appointment

A meeting with no attendees is treated as an appointment by EWS.
To workaround this problem we need to add the "Organizator" as an
attendee, if we don't have any other. And we never should remove him
from attendee's list, once he is only added when is really necessary.
Comment 2 Milan Crha 2013-06-24 10:27:16 UTC
Review of attachment 247576 [details] [review]:

Looks fine, please fix the one coding style issue, and commit to master and gnoem-3-8 branches. Thanks.

::: src/calendar/e-cal-backend-ews-utils.c
@@ +98,3 @@
+
+	if (*required == NULL && *optional == NULL && *resource == NULL && org_email_address != NULL)
+		*required = g_slist_prepend (*required, (gpointer)org_email_address);

missing white-space after (gpointer)
Comment 4 Milan Crha 2013-08-16 09:40:51 UTC
Created attachment 251808 [details] [review]
ews patch (regression fix)

for evolution-ews;

Err, this has a regression, user is not able to create appointments at all, only meetings. The returned error is:
> Could not create the object! Cannot create calendar object: The request
> failed schema validation: The 'http://schemas.microsoft.com/exchange/
> services/2006/types:EmailAddress' element is invalid - The value '' is
> invalid according to its datatype 'http://schemas.microsoft.com/exchange
> /services/2006/types:NonEmptyStringType' - The actual length is less than
> the MinLength value.

which is due to the XML, which looks like:
> <RequiredAttendees>
>     <Attendee><Mailbox><EmailAddress/></Mailbox></Attendee>
> </RequiredAttendees>

which is caused by an overlook that e_ews_collect_organizer() returns an empty string, instead of NULL. I added this check there, same as few more checks when gathering attendees, to avoid this error.
Comment 5 Milan Crha 2013-08-16 09:42:44 UTC
Created commit 286ab97 in ews master (3.9.90+)