After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702879 - Add support for multimedia keys
Add support for multimedia keys
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 700796 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-06-23 02:25 UTC by Fabiano Fidêncio
Modified: 2013-06-23 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for multimedia keys (2.95 KB, patch)
2013-06-23 02:26 UTC, Fabiano Fidêncio
committed Details | Review
Avoid to play a song without a selected playlist (1.16 KB, patch)
2013-06-23 02:26 UTC, Fabiano Fidêncio
committed Details | Review
Fix Prev/Next when the song is Paused (1.09 KB, patch)
2013-06-23 02:27 UTC, Fabiano Fidêncio
committed Details | Review
Avoid crash using Previous/Next (multimedia keys) (1.20 KB, patch)
2013-06-23 02:27 UTC, Fabiano Fidêncio
committed Details | Review

Description Fabiano Fidêncio 2013-06-23 02:25:58 UTC
See the patches
Comment 1 Fabiano Fidêncio 2013-06-23 02:26:55 UTC
Created attachment 247541 [details] [review]
Add support for multimedia keys
Comment 2 Fabiano Fidêncio 2013-06-23 02:26:59 UTC
Created attachment 247542 [details] [review]
Avoid to play a song without a selected playlist
Comment 3 Fabiano Fidêncio 2013-06-23 02:27:04 UTC
Created attachment 247543 [details] [review]
Fix Prev/Next when the song is Paused
Comment 4 Fabiano Fidêncio 2013-06-23 02:27:08 UTC
Created attachment 247544 [details] [review]
Avoid crash using Previous/Next (multimedia keys)

Only call _get{Previous,Next}Track if there is a previous/next track.
We didn't need to check it before because the Previous/Next buttons are
disabled in the first/last playlist's track. Now, with the Multimedia
keys we need to force the same behavior.
Comment 5 Seif Lotfy 2013-06-23 13:44:11 UTC
GREAT JOB
Please push
Comment 6 Fabiano Fidêncio 2013-06-23 16:44:26 UTC
*** Bug 700796 has been marked as a duplicate of this bug. ***