Bug 702822 – Use GtkHeaderBar and csd

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 702822 - Use GtkHeaderBar and csd


Summary:	Use GtkHeaderBar and csd

Reported:	2013-06-21 15:12 UTC by Ignacio Casal Quinteiro (nacho)
Modified:	2013-06-24 09:10 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Use headerbar (651 bytes, patch) 2013-06-21 15:12 UTC, Ignacio Casal Quinteiro (nacho)	committed	Details \| Review
Set headerbar as titlebar (1.36 KB, patch) 2013-06-21 15:12 UTC, Ignacio Casal Quinteiro (nacho)	none	Details \| Review
Add close button (1.52 KB, patch) 2013-06-21 15:12 UTC, Ignacio Casal Quinteiro (nacho)	none	Details \| Review
Do not show close button on selection mode (1.15 KB, patch) 2013-06-21 15:12 UTC, Ignacio Casal Quinteiro (nacho)	none	Details \| Review
Fix for latest update on libgd (3.26 KB, patch) 2013-06-21 15:12 UTC, Ignacio Casal Quinteiro (nacho)	none	Details \| Review
Do not get the spinner rendered (1.93 KB, patch) 2013-06-21 15:12 UTC, Ignacio Casal Quinteiro (nacho)	none	Details \| Review
Use headerbar (651 bytes, patch) 2013-06-21 16:32 UTC, Vadim Rutkovsky	committed	Details \| Review
Do not get the spinner rendered (1.93 KB, patch) 2013-06-21 16:42 UTC, Vadim Rutkovsky	committed	Details \| Review
Fix for latest update on libgd (3.26 KB, patch) 2013-06-21 16:42 UTC, Vadim Rutkovsky	committed	Details \| Review
Set headerbar as titlebar (2.72 KB, patch) 2013-06-21 17:36 UTC, Ignacio Casal Quinteiro (nacho)	committed	Details \| Review
Set headerbar as titlebar (2.74 KB, patch) 2013-06-24 09:10 UTC, Vadim Rutkovsky	committed	Details \| Review

Description Ignacio Casal Quinteiro (nacho) 2013-06-21 15:12:02 UTC

These set of patches ports to GtkHeaderBar and makes use of CSD

Comment 1 Ignacio Casal Quinteiro (nacho) 2013-06-21 15:12:07 UTC

Created attachment 247453 [details] [review]
Use headerbar

Comment 2 Ignacio Casal Quinteiro (nacho) 2013-06-21 15:12:11 UTC

Created attachment 247454 [details] [review]
Set headerbar as titlebar

Comment 3 Ignacio Casal Quinteiro (nacho) 2013-06-21 15:12:14 UTC

Created attachment 247455 [details] [review]
Add close button

Comment 4 Ignacio Casal Quinteiro (nacho) 2013-06-21 15:12:18 UTC

Created attachment 247456 [details] [review]
Do not show close button on selection mode

Comment 5 Ignacio Casal Quinteiro (nacho) 2013-06-21 15:12:21 UTC

Created attachment 247457 [details] [review]
Fix for latest update on libgd

Comment 6 Ignacio Casal Quinteiro (nacho) 2013-06-21 15:12:25 UTC

Created attachment 247458 [details] [review]
Do not get the spinner rendered

Comment 7 Vadim Rutkovsky 2013-06-21 16:32:07 UTC

Comment on attachment 247453 [details] [review]
Use headerbar

The following fix has been pushed:
794efaf Use headerbar

Comment 8 Vadim Rutkovsky 2013-06-21 16:32:11 UTC

Created attachment 247465 [details] [review]
Use headerbar

Comment 9 Vadim Rutkovsky 2013-06-21 16:42:03 UTC

The following fixes have been pushed:
53bbff7 Do not get the spinner rendered
5f8d8ab Fix for latest update on libgd

Comment 10 Vadim Rutkovsky 2013-06-21 16:42:07 UTC

Created attachment 247468 [details] [review]
Do not get the spinner rendered

Comment 11 Vadim Rutkovsky 2013-06-21 16:42:11 UTC

Created attachment 247469 [details] [review]
Fix for latest update on libgd

Comment 12 Vadim Rutkovsky 2013-06-21 16:43:20 UTC

Please squash patches into one for csd - all the rest have been pushed in master

Comment 13 Ignacio Casal Quinteiro (nacho) 2013-06-21 17:36:12 UTC

Created attachment 247478 [details] [review]
Set headerbar as titlebar

Comment 14 Vadim Rutkovsky 2013-06-24 09:10:33 UTC

The following fix has been pushed:
94879a8 Set headerbar as titlebar

Comment 15 Vadim Rutkovsky 2013-06-24 09:10:39 UTC

Created attachment 247604 [details] [review]
Set headerbar as titlebar