After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702810 - Field for entering address is missing when adding new contact
Field for entering address is missing when adding new contact
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.8.x
Other Linux
: Normal major
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on: 699324
Blocks:
 
 
Reported: 2013-06-21 12:34 UTC by Martin Holec
Modified: 2014-12-18 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (18.02 KB, image/png)
2013-06-21 12:34 UTC, Martin Holec 		  Details
proposed patch (1.82 KB, patch)
2014-12-17 14:43 UTC, David King 		committed Details | Review

Description Martin Holec 2013-06-21 12:34:27 UTC 
Field for entering address is missing when adding new contact.

1. Run Contacts
2. Click "New"

see screenshot
Comment 1 Martin Holec 2013-06-21 12:34:55 UTC 
Created attachment 247428 [details]
screenshot
Comment 2 Martin Holec 2013-06-21 12:51:39 UTC 
This is reproducible only when contact book is empty.
Comment 3 Kévin THIERRY 2013-11-13 12:47:26 UTC 
Bug not present on Fedora 20 (gnome-contacts 3.10).
Comment 4 Kévin THIERRY 2013-11-13 13:04:06 UTC 
Bug not present on OpenSUSE 12.3 (gnome-contacts 3.6).
Comment 5 Kévin THIERRY 2013-11-14 10:34:28 UTC 
Bug is also in Fedora 20. I missed it because it only works when no contact has been added. If you have contacts, removing them is not enough to reproduce the bug, you also need to quit gnome-contacts and launch it again.

I tested again OpenSUSE 12.3 and it works fine so the bug is not present in gnome 3.6 but present in gnome 3.8 and 3.10.
Comment 6 Erick Perez Castellanos 2013-11-16 16:36:18 UTC 
Hopefully this will go away once I add inline contact creation
Comment 7 Erick Perez Castellanos 2014-08-11 13:07:34 UTC 
Closing this as fixed since New Contact dialog has gone and we have inline contact creation since: https://git.gnome.org/browse/gnome-contacts/commit/?id=a76f8ee95364a77cb95dad6e6e94cdebe7cbbb20
Comment 8 David King 2014-12-17 14:42:39 UTC 
This should probably have been closed as OBSOLETE, rather than FIXED. Anyway, I fixed (or worked around) the bug, and will attach a patch.
Comment 9 David King 2014-12-17 14:43:01 UTC 
Created attachment 292906 [details] [review]
proposed patch
Comment 10 Erick Perez Castellanos 2014-12-17 15:00:41 UTC 
(In reply to comment #9)
> Created an attachment (id=292906) [details] [review]
> proposed patch

You want me commit this on a 3.8 branch?
Comment 11 David King 2014-12-17 15:06:12 UTC 
That would be great! Does it also affect 3.10 (it seems so, based on comment #5)?
Comment 12 David King 2014-12-18 14:45:32 UTC 
Review of attachment 292906 [details] [review]:

Pushed to gnome-3-8 and gnome-3-10 branches.