After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702793 - query hash_table always gets destroyed instead of unref'd
query hash_table always gets destroyed instead of unref'd
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: API
2.43.x
Other All
: Normal trivial
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2013-06-21 08:02 UTC by Bernhard Schuster
Modified: 2013-06-28 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch v1 (874 bytes, patch)
2013-06-21 08:02 UTC, Bernhard Schuster 		committed Details | Review

Description Bernhard Schuster 2013-06-21 08:02:08 UTC 
Created attachment 247408 [details] [review]
Patch v1

I tried to use the query in a subthrea and jsut called 

g_hash_table_ref/unref to do so, but all I got was a SIGFPE due to the fact (depends on the scheduler) the query object being used was destroyed in the meantime.

Also creating a copy is suboptimal, just a waste of cycles.

Minor patch attached to replace the _destroy by _unref.

Patch is based ontop of commit 38c79e2389855828a6505b635fec688ef1f30116
Comment 1 Dan Winship 2013-06-28 12:39:05 UTC 
sure, makes sense. committed to master.