GNOME Bugzilla – Bug 702760
Use in rtl-symbolic instead in symbol in the opposite direction
Last modified: 2013-08-12 11:14:06 UTC
Created attachment 247363 [details] [review] Use in rtl-symbolic instead in symbol in the opposite direction See patch.
Looks reasonable, is there any way to test this (or please give links to similar patches)
Of course: In goobox: https://bugzilla.gnome.org/show_bug.cgi?id=702661 In gnome-clocks: https://bugzilla.gnome.org/show_bug.cgi?id=702589
You push the patch?
Thanks, pushed, please verify The following fix has been pushed: 9945025 Use in rtl-symbolic instead in symbol in the opposite direction
Created attachment 248114 [details] [review] Use in rtl-symbolic instead in symbol in the opposite direction
Requires many fixes: media-playback-start-symbolic in LTR, media-playback-start-rtl-symbolic in RTL: https://git.gnome.org/browse/gnome-music/tree/data/PlayerToolbar.ui#n389 https://git.gnome.org/browse/gnome-music/tree/src/view.js#n44 https://git.gnome.org/browse/gnome-music/tree/src/widgets.js#n39 media-skip-forward-symbolic in LTR, media-skip-forward-rtl-symbolic in RTL: https://git.gnome.org/browse/gnome-music/tree/data/PlayerToolbar.ui#n30 media-skip-backward-symbolic in LTR, media-skip-backward-rtl-symbolic in RTL: https://git.gnome.org/browse/gnome-music/tree/data/PlayerToolbar.ui#n396 See the bug in totem: https://bugzilla.gnome.org/show_bug.cgi?id=702631 (I'm not a programmer in JavaScript)
(In reply to comment #5) > Created an attachment (id=248114) [details] [review] > Use in rtl-symbolic instead in symbol in the opposite direction verified.
(In reply to comment #6) > Requires many fixes: Reopening
Created attachment 251335 [details] Screenshot - before
Created attachment 251336 [details] Screenshot - after
Thanks for Arnel A. Borja for his work - for this fix: https://git.gnome.org/browse/gnome-music/commit/?id=cf8c8c80ce400220b23f932198340fa3f1e6e307