GNOME Bugzilla – Bug 702741
7.3.122.8: Rygel must check supplied createClass
Last modified: 2013-08-01 09:14:22 UTC
When a client tries to create a container, it can also supply a createClass. Rygel needs to check whether the supplied class is actually supported and report 712 if it doesn't.
Patch attached fixes the validation of createClass value
Created attachment 250146 [details] [review] Validate createClass value
Review of attachment 250146 [details] [review]: Thanks, couple of things: - The indenting is completely weird - The error message should be marked translatable using _(). For this to work the string can't be concatenated I'd suggest extracting this into a helper method
Created attachment 250376 [details] [review] Validate createClass value updated as per review
Pushed with minor changes. It's not necessary to check a GList's length. If the list is non-null, the length can never be 0, see https://git.gnome.org/browse/glib/tree/glib/glist.c?h=glib-2-36#n910