After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702730 - upnp: Disappearing sources are not unregistered
upnp: Disappearing sources are not unregistered
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-20 10:38 UTC by Emanuele Aina
Modified: 2013-06-21 07:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
upnp: Really unregister disappearing sources (1.13 KB, patch)
2013-06-20 10:38 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-06-20 10:38:08 UTC 
It seems that while fixing a race condition in 39437df a call to
grl_registry_unregister_source() went missing and when UPnP sources go away
they are not removed.
Comment 1 Emanuele Aina 2013-06-20 10:38:10 UTC 
Created attachment 247309 [details] [review]
upnp: Really unregister disappearing sources

Unregister the corresponding GrlSource when a UPnP server is being
turned off. It seems that the _unregister() call got lost in 39437df.
Comment 2 Juan A. Suarez Romero 2013-06-21 07:52:21 UTC 
commit 1dd612f7040c1c7728b4cc6ce1f12b38ae17214c
Author: Emanuele Aina <emanuele.aina@collabora.com>
Date:   Thu Jun 20 12:18:53 2013 +0200

    upnp: Really unregister disappearing sources
    
    Unregister the corresponding GrlSource when a UPnP server is being
    turned off. It seems that the _unregister() call got lost in 39437df.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=702730

 src/upnp/grl-upnp.c | 7 +++++++
 1 file changed, 7 insertions(+)


Attachment 247309 [details] pushed as 1dd612f - upnp: Really unregister disappearing sources