After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702684 - shmsink: shared memory filled when no clients connected
shmsink: shared memory filled when no clients connected
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.1.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-19 19:51 UTC by Aleix Conchillo Flaqué
Modified: 2013-06-19 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
unref buffer if no clients connected (1.15 KB, patch)
2013-06-19 19:54 UTC, Aleix Conchillo Flaqué
none Details | Review

Description Aleix Conchillo Flaqué 2013-06-19 19:51:08 UTC
With the latest changes (custom allocator) shared memory space will be filled even no clients are connected. shmsink will then block until it can allocate a new block in the shared memory area. But this will not happen as no one has received the commands of new buffers.
Comment 1 Aleix Conchillo Flaqué 2013-06-19 19:54:19 UTC
Created attachment 247286 [details] [review]
unref buffer if no clients connected
Comment 2 Olivier Crête 2013-06-19 22:37:07 UTC
Committed

commit 44807dcc1a4052f460d06f3b9b29e45c12e17113
Author: Aleix Conchillo Flaque <aleix@oblong.com>
Date:   Wed Jun 19 12:52:52 2013 -0700

    shmsink: unref buffer if no clients are connected
    
    If no client has received the command, unref the buffer. This will
    make sure that the shared memory area does not get filled with buffers
    no one knows about.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=702684