After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702659 - Set button arrow icons according to locale's text direction
Set button arrow icons according to locale's text direction
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-19 14:27 UTC by Yosef Or Boczko
Modified: 2013-06-19 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set button arrow icons according to locale's text direction (1.52 KB, patch)
2013-06-19 14:27 UTC, Yosef Or Boczko 		committed Details | Review
Set button arrow icons according to locale's text direction (1.52 KB, patch)
2013-06-19 16:01 UTC, Yosef Or Boczko 		none Details | Review

Description Yosef Or Boczko 2013-06-19 14:27:28 UTC 
Created attachment 247262 [details] [review]
Set button arrow icons according to locale's text direction

See patch.
Comment 1 Cosimo Cecchi 2013-06-19 15:11:28 UTC 
Review of attachment 247262 [details] [review]:

Looks good! Please fix the indentation before pushing to git master.

::: src/font-view.c
@@ +527,3 @@
     gd_header_button_set_label (GD_HEADER_BUTTON (self->back_button), _("Back"));
+    gd_header_button_set_symbolic_icon_name (GD_HEADER_BUTTON (self->back_button), 
+											 rtl ? "go-previous-rtl-symbolic" : "go-previous-symbolic");

The indentation here is off.
Comment 2 Yosef Or Boczko 2013-06-19 16:01:34 UTC 
Created attachment 247269 [details] [review]
Set button arrow icons according to locale's text direction

Is it okay now?
Comment 3 Cosimo Cecchi 2013-06-19 16:09:15 UTC 
No, it's the same as before - do you have a GNOME git account?
Comment 4 Yosef Or Boczko 2013-06-19 16:12:09 UTC 
No, I do not have GNOME git account.
Comment 5 Cosimo Cecchi 2013-06-19 16:45:39 UTC 
Attachment 247262 [details] pushed as f04f3c0 - Set button arrow icons according to locale's text direction

OK, I pushed a patch with the indentation fixed for you to git. Thanks!