After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702633 - Uploading with HTTP Post throws criticals
Uploading with HTTP Post throws criticals
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
git master
Other Linux
: Normal normal
: ---
Assigned To: Jens Georg
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-19 10:22 UTC by Jens Georg
Modified: 2013-08-06 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-export: Fix crash on item removal (1.54 KB, patch)
2013-08-05 14:54 UTC, Jens Georg 		committed Details | Review
server: Dequeue item upon manual removal (1.18 KB, patch)
2013-08-06 08:51 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2013-06-19 10:22:26 UTC 
(lt-rygel:11855): MediaExport-CRITICAL **: rygel_media_export_media_cache_remove_object: assertion `object != NULL' failed

(lt-rygel:11855): MediaExport-CRITICAL **: rygel_media_export_trackable_db_container_on_child_removed: assertion `object != NULL' failed
Comment 1 Jens Georg 2013-07-22 18:52:12 UTC 
Apparently object removal queue triggers on an object that already has been destroyed and happens after upload of LPCM data.
Comment 2 Jens Georg 2013-08-05 14:54:59 UTC 
Created attachment 250886 [details] [review]
media-export: Fix crash on item removal

MediaCache.get_object can return null if the object wasn't found in the
cache. On certain conditions this can happen while uploading (removal
queue vs. manual remove from client). Take this into account and just
warn instead of crash.
Comment 3 Jens Georg 2013-08-06 08:51:43 UTC 
Created attachment 250944 [details] [review]
server: Dequeue item upon manual removal

If the client creates an object in DLNA.ORG_AnyContainer but doesn't
upload anything to it and then removes it within the 35s timeout, the
ObjectRemovalQueue would still trigger and cause criticals.

This change just tries to dequeue everything we remove to fix this.
Comment 4 Jens Georg 2013-08-06 13:18:51 UTC 
Comment on attachment 250944 [details] [review]
server: Dequeue item upon manual removal

Attachment 250944 [details] pushed as 2728cfb - server: Dequeue item upon manual removal