After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702627 - Set button arrow icons according to locale's text direction
Set button arrow icons according to locale's text direction
Status: VERIFIED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
2.99.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-19 09:35 UTC by Yosef Or Boczko
Modified: 2013-08-04 00:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set button arrow icons according to locale's text direction (2.46 KB, patch)
2013-06-19 09:35 UTC, Yosef Or Boczko 		none Details | Review
Set button play and arrows icons according to locale's text direction (3.04 KB, patch)
2013-06-19 22:22 UTC, Yosef Or Boczko 		none Details | Review
entry-view: set button arrow icons according to locale's text direction (1.02 KB, patch)
2013-08-03 23:34 UTC, Yosef Or Boczko 		none Details | Review

Description Yosef Or Boczko 2013-06-19 09:35:14 UTC 
Created attachment 247244 [details] [review]
Set button arrow icons according to locale's text direction

See patch.
Comment 1 Yosef Or Boczko 2013-06-19 22:22:56 UTC 
Created attachment 247293 [details] [review]
Set button play and arrows icons according to locale's text direction

It also fixes the play button.
Comment 2 Jonathan Matthew 2013-06-21 11:54:46 UTC 
Thanks for pointing this out. I'm currently in the middle of reworking the playback buttons, so I'm not going to use this exact patch, but I have applied equivalent changes to the branch I'm working on.
Comment 3 Jonathan Matthew 2013-07-01 13:17:04 UTC 
This went in as part of commit 5787b2b.
Comment 4 Yosef Or Boczko 2013-07-01 13:26:51 UTC 
Thanks.
Comment 5 Yosef Or Boczko 2013-08-03 23:34:06 UTC 
Created attachment 250782 [details] [review]
entry-view: set button arrow icons according to locale's text direction
Comment 6 Jonathan Matthew 2013-08-03 23:48:23 UTC 
I'm not sure what you were trying to do there, but VERIFIED INCOMPLETE is definitely not the bug status you want.
Comment 7 Yosef Or Boczko 2013-08-03 23:49:55 UTC 
I find status not fixed incomplete.
What status need to set?
Comment 8 Jonathan Matthew 2013-08-03 23:57:23 UTC 
If you're going to attach an entirely new patch for a bug that has already been closed, open a new bug.
Comment 9 Yosef Or Boczko 2013-08-03 23:58:45 UTC 
Also if the patch for same bug?
Comment 10 Jonathan Matthew 2013-08-04 00:05:41 UTC 
yes.