Created attachment 247328 [details] [review]
Implement printing

Review of attachment 247328 [details] [review]:

Looks perfect otherwise and I have seen it in action, live :) Would be better to put the printing code into a separate module/class though.

::: src/mapView.js
@@ +124,3 @@
+
+        try {
+            //this._printOperation.run(Gtk.PrintOperationAction.PREVIEW, null);

This needs removing..

@@ +143,3 @@
+        let stride = stage.get_width() * 4;
+        let pixbuf = GdkPixbuf.Pixbuf.new_from_data(imageData,
+                                         GdkPixbuf.Colorspace.RGB,

args not aligned

Created attachment 247330 [details] [review]
Implement printing

Review of attachment 247330 [details] [review]:

Looks good otherwise.

::: src/mainWindow.js
@@ +231,3 @@
 
+    _onPrintActivate: function() {
+        this._printer = new Printer.Printer(this.window);

we should just pass 'this' here or also 'mapView.view.' so Printer.print() doesn't need any arg.

::: src/printer.js
@@ +58,3 @@
+
+    onPrintPage: function(printOperation, printContext, pageNumber) {
+

Redundant line

Created attachment 247341 [details] [review]
Implement printing

Review of attachment 247341 [details] [review]:

ACK

Oh, this is fixed already.

This is still waiting on the clutter changes in https://bugzilla.gnome.org/show_bug.cgi?id=702754

(In reply to comment #8)
> This is still waiting on the clutter changes in
> https://bugzilla.gnome.org/show_bug.cgi?id=702754

Yikes, i read the status of the patch as 'committed'. :) Whats the dependent bug waiting on, it seems to have a working patch. :( We should have followed up on this to get this in 3.10 but oh well there is always 3.12. :)