After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702577 - Update to new libimobiledevice api
Update to new libimobiledevice api
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afc backend and volume monitor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-18 15:50 UTC by Ondrej Holy
Modified: 2013-06-19 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
update to new libimobiledevice api (8.82 KB, patch)
2013-06-18 15:50 UTC, Ondrej Holy 		needs-work Details | Review
update to new libimobiledevice api (8.79 KB, patch)
2013-06-19 08:08 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2013-06-18 15:50:27 UTC 
Created attachment 247182 [details] [review]
update to new libimobiledevice api

The afc backend needs upgrade to new libimobiledevice api. I've commited by mistake before while.

commit 80d83ce120fc0af69ef61abfeea96604c0190cadq

Should I revert it?

More info: https://bugzilla.redhat.com/show_bug.cgi?id=951731
Comment 1 Bastien Nocera 2013-06-18 18:54:21 UTC 
Review of attachment 247182 [details] [review]:

::: configure.ac
@@ +381,3 @@
                      [AC_DEFINE(HAVE_LIBIMOBILEDEVICE_1_1_2, 1,
                                 [Define to 1 if libimobiledevice-1.1.2 found])])
+    PKG_CHECK_EXISTS(libimobiledevice-1.0 >= 1.1.5,

1.1.2 is an unstable release, just bump the minimum dep to 1.1.5 instead and remove all the ifdefs.

This should go to gnome-3-8 as well.
Comment 2 Ondrej Holy 2013-06-19 08:08:05 UTC 
Created attachment 247237 [details] [review]
update to new libimobiledevice api

bump to 1.1.5 and remove ifdefs
Comment 3 Bastien Nocera 2013-06-19 08:37:41 UTC 
Review of attachment 247237 [details] [review]:

Looks good.
Comment 4 Bastien Nocera 2013-06-19 08:49:31 UTC 
Review of attachment 247237 [details] [review]:

Looks good.
Comment 5 Ondrej Holy 2013-06-19 12:01:17 UTC 
Committed to the both branches.

master:
commit 80d83ce120fc0af69ef61abfeea96604c0190cadq
commit 53f086bdb30a1cc582ed7064bbf69f931b398134

gnome-3-8:
commit d71c6108901460842de25012d5ece727a0c70d27