After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702565 - Load cover art on scroll in Albums and Artists view
Load cover art on scroll in Albums and Artists view
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Vadim Rutkovsky
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-18 14:17 UTC by Arnel Borja
Modified: 2014-04-28 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implementation on Albums view (3.14 KB, patch)
2013-06-18 14:25 UTC, Arnel Borja
needs-work Details | Review
Load cover art on scroll in Albums view (3.16 KB, patch)
2013-07-03 13:26 UTC, Arnel Borja
none Details | Review
Load cover art on scroll in Albums view (3.21 KB, patch)
2013-07-03 13:35 UTC, Arnel Borja
needs-work Details | Review
Load thumbnails for visible elements only + 10 next (3.12 KB, patch)
2013-08-28 12:08 UTC, Vadim Rutkovsky
needs-work Details | Review

Description Arnel Borja 2013-06-18 14:17:34 UTC
We should load the cover art once the user scrolls to them to minimize the amount of background tasks at populate.
Comment 1 Arnel Borja 2013-06-18 14:25:07 UTC
Created attachment 247155 [details] [review]
Implementation on Albums view

Haven't check this much, so probably not good for commit yet.

I might move the loading from ViewContainer to AlbumsView because ViewContainer is also used for the left pane of Artists view. That code is unnecessary there. Don't know if I should override _onScrolledWinChange (I'm new to JS), because it seems like it is supposed to be a private function.

Also, I added a new column to the list store to know if loading the cover art is already queued.

I haven't looked yet at the right pane of Artists view for loading on-scroll there. It doesn't use a GtkIconView, so implementation there would be different.
Comment 2 Vadim Rutkovsky 2013-06-21 20:15:17 UTC
Review of attachment 247155 [details] [review]:

Please rebase on top of latest master, it had some changes in adding in this._model.set due to libgd update

This patch also breaks tests - hang up in tests_albumPlayback.js
Comment 3 Arnel Borja 2013-07-03 13:26:46 UTC
Created attachment 248308 [details] [review]
Load cover art on scroll in Albums view

This will start the loading of cover art once the user scrolls to it,
minimizing the amount of background tasks on populate.
Comment 4 Arnel Borja 2013-07-03 13:31:39 UTC
Rebased the patch and moved loading on-load to the AlbumsView since it is not used on the other views. The test is still broken - we have to find a new way to detect if the first load of albums is already finished.

I think this patch is ready for commit, we could fix the Artists view later (we could keep this bug open while that part is not yet finished).
Comment 5 Arnel Borja 2013-07-03 13:35:47 UTC
Created attachment 248310 [details] [review]
Load cover art on scroll in Albums view

This will start the loading of cover art once the user scrolls to it,
minimizing the amount of background tasks on populate.
Comment 6 Arnel Borja 2013-07-03 13:37:48 UTC
Comment on attachment 247155 [details] [review]
Implementation on Albums view

Obsolete this. I updated the latest patch to remove a possible deadlock.
Comment 7 Vadim Rutkovsky 2013-07-07 10:49:49 UTC
Review of attachment 248310 [details] [review]:

Looks nice, but Albums view blinks each time a cover is being fetched
Comment 8 Vadim Rutkovsky 2013-08-28 12:08:21 UTC
Created attachment 253369 [details] [review]
Load thumbnails for visible elements only + 10 next
Comment 9 Arnel Borja 2013-09-08 04:23:10 UTC
Review of attachment 253369 [details] [review]:

Needs rebase to current master branch.
Comment 10 Vadim Rutkovsky 2014-04-28 11:08:38 UTC
Rebased on master and pushed to https://git.gnome.org/browse/gnome-music/commit/?id=05b8bf2 (will appear in 3.13.1)