After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702536 - network: Don't hide the VPN icon
network: Don't hide the VPN icon
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-18 08:39 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-09-12 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Don't hide the VPN icon (997 bytes, patch)
2013-06-18 08:39 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
Gap in status icons (5.39 KB, image/png)
2013-06-18 13:34 UTC, Florian Müllner 		  Details
network: Fix visibility of the VPN icon (1.11 KB, patch)
2013-06-23 00:18 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
Double-vision network icon (1.09 KB, image/png)
2013-06-24 19:52 UTC, Florian Müllner 		  Details
network: Fix visibility of the VPN icon (1.11 KB, patch)
2013-07-01 17:21 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
network: Prioritize active / default connections over activating ones (921 bytes, patch)
2013-07-01 17:21 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-06-18 08:39:26 UTC 
This is a regression from e6c239d0f3318984815049abb621f6b0cb3dc85e,
where we removed the calls to hide()/show() when we had a VPN device
vs. not. Having a null icon-name is enough to make it invisible.
This fixes the VPN icon being invisible forever.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-06-18 08:39:30 UTC 
Created attachment 247099 [details] [review]
network: Don't hide the VPN icon
Comment 2 Florian Müllner 2013-06-18 13:34:16 UTC 
Created attachment 247142 [details]
Gap in status icons

(In reply to comment #0)
> Having a null icon-name is enough to make it invisible.

Except that it will still take up space, see screenshot.
Comment 3 drago01 2013-06-22 07:50:07 UTC 
Review of attachment 247099 [details] [review]:

See Florian's comment.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-06-23 00:18:53 UTC 
Created attachment 247539 [details] [review]
network: Fix visibility of the VPN icon

This is a regression from e6c239d0f3318984815049abb621f6b0cb3dc85e,
where we removed the calls to hide()/show() when we had a VPN device
vs. not.
Comment 5 Florian Müllner 2013-06-24 19:52:32 UTC 
Created attachment 247680 [details]
Double-vision network icon

Still not right, see screenshot.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-07-01 17:21:39 UTC 
Created attachment 248167 [details] [review]
network: Fix visibility of the VPN icon

This is a regression from e6c239d0f3318984815049abb621f6b0cb3dc85e,
where we removed the calls to hide()/show() when we had a VPN device
vs. not.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-07-01 17:21:43 UTC 
Created attachment 248168 [details] [review]
network: Prioritize active / default connections over activating ones
Comment 8 Florian Müllner 2013-07-11 15:35:33 UTC 
Review of attachment 248167 [details] [review]:

OK
Comment 9 Florian Müllner 2013-07-11 15:35:53 UTC 
Review of attachment 248168 [details] [review]:

OK
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-08-05 19:19:59 UTC 
Attachment 248167 [details] pushed as 621810c - network: Fix visibility of the VPN icon
Attachment 248168 [details] pushed as 4d34abe - network: Prioritize active / default connections over activating ones
Comment 11 David Woodhouse 2013-09-12 20:30:06 UTC 
Is this also the cause of the breakage in gnome-3-8?
https://bugzilla.redhat.com/show_bug.cgi?id=980467
Comment 12 Florian Müllner 2013-09-12 21:33:55 UTC 
No, this fixes a regression that was introduced during the 3.10 cycle.