After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702535 - List box doesn't expand to fill window
List box doesn't expand to fill window
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
: 710537 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-06-18 08:05 UTC by Vidar Braut Haarr
Modified: 2013-10-25 03:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Zenity running repostory (65.16 KB, image/png)
2013-10-10 18:03 UTC, Arx Cruz
Details
zenity single line error with repostory (16.88 KB, image/png)
2013-10-10 18:28 UTC, FBrown
Details
fixed as per previous suggestion (44.66 KB, image/png)
2013-10-10 18:33 UTC, FBrown
Details

Description Vidar Braut Haarr 2013-06-18 08:05:13 UTC
Try downloading repostory on a debian/ubuntu system and run it. Notice how the list doesn't fill up the window - it remains at the height of a single entry.

Adding this line at line 1024 in /usr/share/zenity/zenity.ui seems to fix it for me, although I don't know if it is the "correct" way of fixing it or not:
<property name="expand">True</property>
Comment 1 Arx Cruz 2013-08-19 11:58:46 UTC
I didn't understand what you mean, can you please provide an example?
Comment 2 Vidar Braut Haarr 2013-08-19 12:01:57 UTC
I did :-) "repostory" is not a typo:
http://ubuntuforums.org/showthread.php?t=1593718
Download that and try it.
Comment 3 Arx Cruz 2013-08-19 12:09:28 UTC
Oh, gotcha! I will fix it :)
Comment 4 Vinicius Silva 2013-08-20 02:11:10 UTC
Hi gentlemen,

This looks to me as a "working as designed". Mainly because it's hardcoded on line 166 of the repostory script, the author clearly passes a "--width 800" parameter.
Comment 5 FBrown 2013-10-10 16:54:45 UTC
(In reply to comment #0)
> Try downloading repostory on a debian/ubuntu system and run it. Notice how the
> list doesn't fill up the window - it remains at the height of a single entry.
> 
> Adding this line at line 1024 in /usr/share/zenity/zenity.ui seems to fix it
> for me, although I don't know if it is the "correct" way of fixing it or not:
> <property name="expand">True</property>

Bug is still present in 3.10, and occurs other than in the repostory script.

I can confirm that that fix to the code solves the problem for me on the repostory AND other unrelated scripts.

(In reply to comment #4)
> Hi gentlemen,
> 
> This looks to me as a "working as designed". Mainly because it's hardcoded on
> line 166 of the repostory script, the author clearly passes a "--width 800"
> parameter.

Removing that from the script does not resolve the problem for me, and it is the height rather than width of the list box that is not filling the dialogue as it should.
Comment 6 Arx Cruz 2013-10-10 18:03:50 UTC
Created attachment 256939 [details]
Zenity running repostory

Unfortunatelly I coudln't add this change in 3.10 due code freeze. However I still didn't understand what you want. Are you talking about the empty space? (Image attached)
Comment 7 FBrown 2013-10-10 18:28:45 UTC
Created attachment 256940 [details]
zenity single line error with repostory

No, the problem is as per the original description.

Single line rather than the list box expanding to fill the dialogue. 

Note that the hard coded window size restraints have been removed from the script for that example, and the result is exactly the same problem. Makes no difference.
Comment 8 FBrown 2013-10-10 18:33:56 UTC
Created attachment 256941 [details]
fixed as per previous suggestion

And attached there the result when applying the suggested fix to /usr/share/zenity/zenity.ui
Comment 9 FBrown 2013-10-10 18:39:18 UTC
Same problem reported here I think? https://bugs.launchpad.net/ubuntu/+source/zenity/+bug/1192101
Comment 10 Arx Cruz 2013-10-10 19:49:01 UTC
Oh, NOW I understand! Sorry, english isn't my main language, so sometimes it take a while to understand.

So, without this option, you can't resize the window for a size, lower than the line, and even if you set the width, the list force the window to keep the size of one single line.

Yes, that's odd, and I will fix it and it will be available in next zenity version.
Comment 11 Arx Cruz 2013-10-10 19:54:14 UTC
Done.

https://git.gnome.org/browse/zenity/commit/?id=80bc8ce643979fec201c4ebd5cd6405b6310357f

Thanks for help zenity get better :)
Comment 12 Arx Cruz 2013-10-25 03:41:42 UTC
*** Bug 710537 has been marked as a duplicate of this bug. ***