After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702501 - account: Only show join enterprise login if we have the capabilities
account: Only show join enterprise login if we have the capabilities
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-17 18:36 UTC by Michael Wood
Modified: 2013-06-21 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
account: Only show join enterprise login if we have the capabilities (1.63 KB, patch)
2013-06-17 18:36 UTC, Michael Wood 		reviewed Details | Review
account: Only show join enterprise login if we have the capabilities (1.36 KB, patch)
2013-06-18 10:51 UTC, Michael Wood 		accepted-commit_now Details | Review

Description Michael Wood 2013-06-17 18:36:57 UTC 
Untested as I don't have any way of getting realmd at the moment.
Comment 1 Michael Wood 2013-06-17 18:36:59 UTC 
Created attachment 247059 [details] [review]
account: Only show join enterprise login if we have the capabilities

Only show this widget if we have realmd available.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-06-17 18:57:57 UTC 
Review of attachment 247059 [details] [review]:

I'd prefer if set_has_enterprise did a gtk_widget_set_visible or similar. I swore we did this before...
Comment 3 Michael Wood 2013-06-18 10:51:51 UTC 
Created attachment 247119 [details] [review]
account: Only show join enterprise login if we have the capabilities

Only show this widget if we have realmd available.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-06-18 17:12:06 UTC 
Review of attachment 247119 [details] [review]:

Yes.
Comment 5 Michael Wood 2013-06-21 10:02:23 UTC 
master 6f4fc76ac35da9661f5833cb668dc706917af683
gnome-3-8 7bd20a19f3356e7f6869afaf7673ac2332005e0f