Bug 702493 – account: Fix segfault on no permission to access accountservice.

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 702493 - account: Fix segfault on no permission to access accountservice.


Summary:	account: Fix segfault on no permission to access accountservice.


Status:	RESOLVED FIXED

Product:	gnome-initial-setup
Classification:	Applications
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Initial Setup maintainer(s)
QA Contact:	GNOME Initial Setup maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-06-17 17:06 UTC by Michael Wood
Modified:	2013-06-17 18:06 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
account: Fix segfault on no permission to access accountservice. (1.46 KB, patch) 2013-06-17 17:06 UTC, Michael Wood	accepted-commit_now	Details \| Review

Description Michael Wood 2013-06-17 17:06:06 UTC

act_user can be NULL if permission denied, or account setup fails
Mostly affects testing mode (--force-new-user).

Comment 1 Michael Wood 2013-06-17 17:06:08 UTC

Created attachment 247052 [details] [review]
account: Fix segfault on no permission to access accountservice.

Comment 2 Michael Wood 2013-06-17 17:06:42 UTC

** (gnome-initial-setup:21158): WARNING **: Failed to create user: GDBus.Error:org.freedesktop.Accounts.Error.PermissionDenied: Not authorized

Program received signal SIGSEGV, Segmentation fault.
act_user_is_loaded (user=0x0) at act-user.c:1519
1519	        return user->is_loaded;
(gdb) bt

+ Trace 232082

#0 act_user_is_loaded
at act-user.c line 1519
#1 local_create_user
at gis-account-page.c line 509
#2 gis_account_page_save_data
at gis-account-page.c line 1133
#3 gis_assistant_save_data
at gis-assistant.c line 404
#4 gis_driver_save_data
at gis-driver.c line 355
#5 gis_summary_page_shown
at gis-summary-page.c line 269
#6 g_closure_invoke
at gclosure.c line 777
#7 signal_emit_unlocked_R
at gsignal.c line 3582
#8 g_signal_emit_valist
at gsignal.c line 3326
#9 g_signal_emit
at gsignal.c line 3382
#10 g_object_dispatch_properties_changed
at gobject.c line 1047
#11 g_object_notify_by_spec_internal
at gobject.c line 1141
#12 g_object_notify
at gobject.c line 1183
#13 set_visible_child
at libgd/gd-stack.c line 780
#14 g_closure_invoke
at gclosure.c line 777
#15 signal_emit_unlocked_R
at gsignal.c line 3620
#16 g_signal_emit_valist
at gsignal.c line 3326
#17 g_signal_emit
at gsignal.c line 3382
#18 on_apply_done
at gis-assistant.c line 105
#19 gis_page_apply_complete
at gis-page.c line 322
#20 gis_page_apply_begin
at gis-page.c line 296
#21 _g_closure_invoke_va
at gclosure.c line 840
#22 g_signal_emit_valist
at gsignal.c line 3234
#23 g_signal_emit
at gsignal.c line 3382
#24 gtk_real_button_released
at gtkbutton.c line 2001
#25 _g_closure_invoke_va
at gclosure.c line 840
#26 g_signal_emit_valist
at gsignal.c line 3234
#27 g_signal_emit
at gsignal.c line 3382
#28 gtk_button_button_release
at gtkbutton.c line 1836
#29 gtk_button_button_release
at gtkbutton.c line 1828
#30 _gtk_marshal_BOOLEAN__BOXEDv
at gtkmarshalers.c line 130
#31 _g_closure_invoke_va
at gclosure.c line 840
#32 g_signal_emit_valist
at gsignal.c line 3234
#33 g_signal_emit
at gsignal.c line 3382
#34 gtk_widget_event_internal
at gtkwidget.c line 6979
#35 gtk_widget_event
at gtkwidget.c line 6636
#36 propagate_event_up
at gtkmain.c line 2393
#37 propagate_event
at gtkmain.c line 2501
#38 gtk_main_do_event
at gtkmain.c line 1716
#39 gdk_event_source_dispatch
at gdkeventsource.c line 364
#40 g_main_dispatch
at gmain.c line 3058
#41 g_main_context_dispatch
at gmain.c line 3634
#42 g_main_context_iterate
at gmain.c line 3705
#43 g_main_context_iteration
at gmain.c line 3766
#44 g_application_run
at gapplication.c line 1638
#45 main
at gnome-initial-setup.c line 250

Comment 3 Jasper St. Pierre (not reading bugmail) 2013-06-17 17:40:28 UTC

Review of attachment 247052 [details] [review]:

OK.

Comment 4 Michael Wood 2013-06-17 18:06:34 UTC

Thanks pushed: 4a1e102da88e27d4b9e63de728a6fb0a810ae9e6