After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702483 - rest_proxy_call_invoke_async: GCancellable needs to be disconnected
rest_proxy_call_invoke_async: GCancellable needs to be disconnected
Status: RESOLVED FIXED
Product: librest
Classification: Platform
Component: proxy
git master
Other Linux
: Normal normal
: ---
Assigned To: librest-maint
librest-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-17 15:48 UTC by Alban Crequy
Modified: 2013-06-17 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] call: disconnect GCancellable 'cancel' signal (2.68 KB, patch)
2013-06-17 15:54 UTC, Alban Crequy 		committed Details | Review

Description Alban Crequy 2013-06-17 15:48:23 UTC 
There is a crash in rest_proxy_call_cancel(). This is because librest connects to the "cancel" signal but does not disconnect when the call object is released. So it calls a method on a released object. There is a FIXME about it in the code:

https://git.gnome.org/browse/librest/tree/rest/rest-proxy-call.c#n923
  // FIXME: disconnect cancellable ?

The following patch fixes this.
Comment 1 Ross Burton 2013-06-17 15:51:56 UTC 
No patch...
Comment 2 Ross Burton 2013-06-17 15:52:13 UTC 
But if it's obviously the right thing to do, just push it.
Comment 3 Alban Crequy 2013-06-17 15:54:28 UTC 
Created attachment 247046 [details] [review]
[PATCH] call: disconnect GCancellable 'cancel' signal
Comment 4 Ross Burton 2013-06-17 16:00:00 UTC 
Review of attachment 247046 [details] [review]:

+1
Comment 5 Alban Crequy 2013-06-17 16:33:59 UTC 
Comment on attachment 247046 [details] [review]
[PATCH] call: disconnect GCancellable 'cancel' signal

Patch committed on git master:
2b363686aa1cbfa2d778a16b813472f1bf309cbf