After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702481 - Change password dialog for my account - minor layout tweak
Change password dialog for my account - minor layout tweak
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-17 15:32 UTC by Allan Day
Modified: 2013-08-05 19:10 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
add padding (1.40 KB, patch)
2013-06-18 13:41 UTC, Ondrej Holy 		none Details | Review
screenshot (15.24 KB, image/png)
2013-06-18 13:41 UTC, Ondrej Holy 		  Details
add padding (1.40 KB, patch)
2013-06-18 15:08 UTC, Ondrej Holy 		committed Details | Review
screenshot (15.30 KB, image/png)
2013-06-18 15:09 UTC, Ondrej Holy 		  Details

Description Allan Day 2013-06-17 15:32:38 UTC 
There should be a bit more padding (6px or 12px) between the current password field and the new password field. This will better communicate that the lower two fields are connected.
Comment 1 Ondrej Holy 2013-06-18 13:41:28 UTC 
Created attachment 247143 [details] [review]
add padding
Comment 2 Ondrej Holy 2013-06-18 13:41:50 UTC 
Created attachment 247144 [details]
screenshot
Comment 3 Allan Day 2013-06-18 14:31:25 UTC 
I think you need more padding here - 12px extra instead of 6px.
Comment 4 Ondrej Holy 2013-06-18 15:08:30 UTC 
Created attachment 247164 [details] [review]
add padding
Comment 5 Ondrej Holy 2013-06-18 15:09:05 UTC 
Created attachment 247165 [details]
screenshot
Comment 6 Allan Day 2013-06-18 16:24:06 UTC 
Thanks for the screenshot. You could have just pushed the updated patch. :)
Comment 7 Thomas Wood 2013-08-02 16:28:16 UTC 
Review of attachment 247164 [details] [review]:

Patch needs rebasing, but otherwise looks fine.
Comment 8 Ondrej Holy 2013-08-05 19:09:48 UTC 
Comment on attachment 247164 [details] [review]
add padding

commit 067d064105dbe8ea341c8270b41a5a63777ff73e