After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702469 - Settings search has inconsistent behavior
Settings search has inconsistent behavior
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-17 14:45 UTC by Ewan.LEBIDEAU-CANEVET
Modified: 2013-06-19 10:11 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
shell: ensure a search is in progress before activating a panel (1.29 KB, patch)
2013-06-18 13:12 UTC, Thomas Wood
needs-work Details | Review

Description Ewan.LEBIDEAU-CANEVET 2013-06-17 14:45:48 UTC
User can notice that searching for something in settings, and then erasing the search criteria, entering on the search field will open random settings tabs.

Steps :

1. Boot System
2. Open system settings
3. On the search bar (top right) click on it to highlight it
4. Press Enter, observe nothing happens
5. Search for a string (my example is string "re")
6. Erase the string, observe search tab is still highlighted and that nothing is selected from the settings sections
7. Press ENTER
8. Observe it opens BACKGROUNDS and sometimes DETAILS

Expected outcome

Nothing opens since nothing is highlighted and on first start pressing enter does not open anything

Actual outcome

System will open random section (mostly backgrounds) from settings section

Note : reproduced on Fedora 19 Beta
Comment 1 Bastien Nocera 2013-06-17 14:53:32 UTC
I can't reproduce this with gnome-control-center 3.8.2
Comment 2 Bastien Nocera 2013-06-17 14:54:24 UTC
Search is for bugs in the search panel, not for the gnome-control-center shell's search
Comment 3 Ewan.LEBIDEAU-CANEVET 2013-06-17 15:26:53 UTC
I'm talking about the search panel in the gnome settings window
Comment 4 Bastien Nocera 2013-06-17 15:37:41 UTC
There's no top-right search bar in the search panel. You're talking about search in the control-center's shell overview.
Comment 5 Ewan.LEBIDEAU-CANEVET 2013-06-18 07:50:48 UTC
I'm talking about the search field you can observe when opening General Settings (gnome-control-center)
Comment 6 Thomas Wood 2013-06-18 13:12:29 UTC
Created attachment 247137 [details] [review]
shell: ensure a search is in progress before activating a panel
Comment 7 Bastien Nocera 2013-06-18 19:00:53 UTC
Review of attachment 247137 [details] [review]:

There's changes to egg-list-box and libgd in your patch.

::: shell/cc-window.c
@@ +630,3 @@
   CcWindowPrivate *priv = self->priv;
 
+  if (event->keyval == GDK_KEY_Return && g_strcmp0 (priv->filter_string, ""))

!= 0
Comment 8 Bastien Nocera 2013-06-18 19:01:46 UTC
> 6. Erase the string, observe search tab is still highlighted and that nothing
> is selected from the settings sections

I still cannot reproduce the problem. Would be good if you could tell me how.
Comment 9 Thomas Wood 2013-06-19 10:11:34 UTC
I think the main issue is that after entering a search term with some results then deleting the search, pressing enter would launch a panel. I've made the suggested changes to the patch and pushed to both master and gnome-3-8 branches.