After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702458 - select password at login
select password at login
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-17 12:54 UTC by Ewan.LEBIDEAU-CANEVET
Modified: 2013-06-18 15:00 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
proposed patch (872 bytes, patch)
2013-06-17 20:13 UTC, Jonh Wendell
reviewed Details | Review

Description Ewan.LEBIDEAU-CANEVET 2013-06-17 12:54:34 UTC
Steps:
1. Go to Settings -> Users. Unlock. Click on password and select: "Choose password at next login"
2. Logout and login
3. Type an invalid password (eq:"q") -> a message saying that password is a palindrom will appear
4. Enter a valid password

expected: the message regarding the palindrom should disappear
actual: the message will not disappear
Comment 1 Jonh Wendell 2013-06-17 20:13:32 UTC
Created attachment 247064 [details] [review]
proposed patch
Comment 2 Ray Strode [halfline] 2013-06-18 13:41:02 UTC
Review of attachment 247064 [details] [review]:

I guess this is probably right.  even if there are a series of messages queued up, they probably are in reference to the prompt query.

::: js/gdm/util.js
@@ +165,3 @@
     answerQuery: function(serviceName, answer) {
         if (!this._userVerifier.hasPendingMessages) {
+            this._clearMessageQueue ();

no space between clearMessageQueue and the ().
Comment 3 Jonh Wendell 2013-06-18 13:58:16 UTC
(In reply to comment #2)
> Review of attachment 247064 [details] [review]:
> 
> I guess this is probably right.  even if there are a series of messages queued
> up, they probably are in reference to the prompt query.

so, should I just fix this and commit?
If so, can I backport this to 3.8?
 
> ::: js/gdm/util.js
> @@ +165,3 @@
>      answerQuery: function(serviceName, answer) {
>          if (!this._userVerifier.hasPendingMessages) {
> +            this._clearMessageQueue ();
> 
> no space between clearMessageQueue and the ().
Comment 4 Jonh Wendell 2013-06-18 15:00:33 UTC
pushed, thanks.