After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702452 - UDA-3.1.3,AV1-MS:1-CD:1-9.1,7.2.16.1: Wrong error codes
UDA-3.1.3,AV1-MS:1-CD:1-9.1,7.2.16.1: Wrong error codes
Status: RESOLVED OBSOLETE
Product: rygel
Classification: Applications
Component: librygel-server
git master
Other Linux
: Normal minor
: ---
Assigned To: rygel-maint
rygel-maint
ivi
Depends on:
Blocks:
 
 
Reported: 2013-06-17 12:09 UTC by Jens Georg
Modified: 2018-05-22 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
server: Use proper error code in ImportResource (2.05 KB, patch)
2013-08-05 13:19 UTC, Jens Georg 		none Details | Review
server: Use correct error code in CreateObject (1.08 KB, patch)
2013-08-05 13:25 UTC, Jens Georg 		none Details | Review
There's now one warning missin: (7.95 KB, patch)
2013-08-05 13:56 UTC, Jens Georg 		none Details | Review
Fix a != vs == issue in old patch (7.95 KB, patch)
2013-08-05 14:10 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2013-06-17 12:09:08 UTC 
We're using wrong error codes, should mostly be 402 (invalid args) instead of the specific 7xx ones or using the wrong 7xx code.
Comment 1 Jens Georg 2013-06-27 09:52:21 UTC 
DLNA test 7.2.16.1 and UPnP CTT seem to slightly disagree on the error codes.
Comment 2 Jens Georg 2013-08-05 13:19:36 UTC 
Created attachment 250874 [details] [review]
server: Use proper error code in ImportResource

Instead of 719 (Destination resource access denied) use 718
(No such destination resource) if the uri can't be parsed.
Comment 3 Jens Georg 2013-08-05 13:25:03 UTC 
Created attachment 250875 [details] [review]
server: Use correct error code in CreateObject
Comment 4 Jens Georg 2013-08-05 13:56:13 UTC 
Created attachment 250881 [details] [review]
There's now one warning missin:

CTT wants us to ignore extra arguments. This is quite annoying because I added
those checks during nokia time because CTT wanted us to not ignore them.

core,server: Use proper error codes

There are several places where the wrong error code was used.
Comment 5 Jens Georg 2013-08-05 14:10:41 UTC 
Created attachment 250882 [details] [review]
Fix a != vs == issue in old patch

core,server: Use proper error codes

There are several places where the wrong error code was used.
Comment 6 GNOME Infrastructure Team 2018-05-22 12:39:19 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rygel/issues/40.