GNOME Bugzilla – Bug 702422
tsparse: Ensure initial events are sent in the right order
Last modified: 2013-06-19 05:41:15 UTC
First send stream-start, then caps, then segment. The segment we push is from upstream in push-mode. If we work in pull-mode then we initialize the base segment to BYTES.
Created attachment 246996 [details] [review] tsparse: Ensure initial events are sent in the right order
Created attachment 246997 [details] [review] tsparse: Ensure initial events are sent in the right order First send stream-start, then caps, then segment. The segment we push is from upstream in push-mode. If we work in pull-mode then we initialize the base segment to BYTES.
Review of attachment 246997 [details] [review]: Looks good to me, the SEGMENT_FORMAT/SEGMENT_ARGS could make it to core ?
You mean GST_SEGMENT_FORMAT from gstinfo.h? :)
Looks generally good to me, but does this ensure that new segment events are sent downstream if the upstream segment changed?
Comment on attachment 246997 [details] [review] tsparse: Ensure initial events are sent in the right order Please push after changing to GST_SEGMENT_FORMAT and ensuring that new upstream segments cause new downstream segments as appropriate
incoming segments are always stored in mpegtsbase->segment and then passed on to tsdemux/tsparse push_event vmethod. If it's the first segment event and we're not ready yet, we delay pushing that segment to later. Otherwise it's pushed along just fine. I'll update to use GST_SEGMENT_FORMAT.
commit e66d543f004a2d06a77f67fd4473918117f7a77b Author: Edward Hervey <edward@collabora.com> Date: Mon Jun 17 08:15:54 2013 +0200 tsparse: Ensure initial events are sent in the right order First send stream-start, then caps, then segment. The segment we push is from upstream in push-mode. If we work in pull-mode then we initialize the base segment to BYTES. https://bugzilla.gnome.org/show_bug.cgi?id=702422