After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702378 - Fix the visibility of the back button when exiting selection mode
Fix the visibility of the back button when exiting selection mode
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-16 01:25 UTC by Giovanni Campagna
Modified: 2013-06-16 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the visibility of the back button when exiting selection mode (3.70 KB, patch)
2013-06-16 01:25 UTC, Giovanni Campagna 		committed Details | Review
Fix the visibility of the back button when exiting selection mode (3.70 KB, patch)
2013-06-16 09:18 UTC, Vadim Rutkovsky 		committed Details | Review

Description Giovanni Campagna 2013-06-16 01:25:10 UTC 
Unconditionally showing the back button on exit is wrong, it needs
to take the toolbar state into account. While we're there, let's
restructure the code more logically, and implement the selection-mode
styling.
Comment 1 Giovanni Campagna 2013-06-16 01:25:14 UTC 
Created attachment 246920 [details] [review]
Fix the visibility of the back button when exiting selection mode
Comment 2 Vadim Rutkovsky 2013-06-16 09:18:46 UTC 
Works great, thanks

The following fix has been pushed:
9a882ef Fix the visibility of the back button when exiting selection mode
Comment 3 Vadim Rutkovsky 2013-06-16 09:18:53 UTC 
Created attachment 246928 [details] [review]
Fix the visibility of the back button when exiting selection mode

Unconditionally showing the back button on exit is wrong, it needs
to take the toolbar state into account. While we're there, let's
restructure the code more logically, and implement the selection-mode
styling.