After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702302 - indent outputted html
indent outputted html
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-streaming-server
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-14 23:22 UTC by Michael Jones
Modified: 2014-02-01 21:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add indenting logic to html output. (100.67 KB, patch)
2013-06-14 23:24 UTC, Michael Jones
rejected Details | Review
Updated patch (100.79 KB, patch)
2013-06-24 18:09 UTC, Michael Jones
rejected Details | Review

Description Michael Jones 2013-06-14 23:22:38 UTC
The attached patch against 

commit a3c05d8c8c1c30ee5c0430c0c331fda434845ecd
Author: David Schleef <ds@schleef.org>
Date:   Thu May 2 12:35:44 2013 -0700

    server: convert to jpeg snapshot replacements

Modifies the GSS_A and GSS_P macros (and adds a few others) to keep track of what indentation level the generated HTML is at, and properly indent subsequently generated HTML. 

This is primarily to make it easy to read the page source in the browser.
Comment 1 Michael Jones 2013-06-14 23:24:41 UTC
Created attachment 246864 [details] [review]
Patch to add indenting logic to html output.
Comment 2 Michael Jones 2013-06-24 18:09:51 UTC
Created attachment 247664 [details] [review]
Updated patch

This version of the patch corrects a few indentation problems.
Comment 3 David Schleef 2013-11-24 01:19:41 UTC
Not going to apply this.  The GSS_A and _P macros are a large enough barrier to getting HTML into the code.  It's quite reasonable to expect a user to reformat the HTML if they want to read it.

That being said, I'd be cool with an HTML formatter built-in to GSS that will optionally reformat after the file is generated.
Comment 4 Tim-Philipp Müller 2013-11-25 15:13:32 UTC
Michael, is that something you would be interested in implementing as well?
Comment 5 Michael Jones 2013-11-25 16:36:50 UTC
@Tim-Philip

    I'm afraid not.

    My original patch was developed as part of a project for my employer, and split out from that work to submit to GSS in the hope that others would find it useful.

    We've since stopped the project that resulted in that patch, and at the moment have no plans to revisit it.

    If the situation changes, we will consider this request.

--Mike